Why is this code not working? (From a site) 2

neillovell · Nov 6, 2002

I've grabbed this code from

But I'm having trouble with the second file. It will not write to my database. The first and second (create form and submit, and display data in table) files are fine, but it's this second...
My database (.mdb) is called TempASPLink and the table fields are firstname and lastname

<HTML>

<HEAD>
<TITLE>Text to Database</TITLE>
</HEAD>

<BODY>

<%
firstname=request.form("firstname&quot

lastname=request.form("lastname&quot

%>

<%
accessdb="TempASPLink"
cn="DRIVER={Microsoft Access Driver (*.mdb)};"
cn=cn & "DBQ=" & server.mappath(accessdb)
set rs = Server.CreateObject("ADODB.Recordset&quot

sql = "insert into testtable (lastname, firstname) "

sql = sql & "values ('" & firstname
sql = sql & "','" & lastname & "')"

rs.Open sql, cn
%>

First Name <%= firstname %>
 
Last Name <%= lastname %>
 
has been added to the db 
<a href = "input_text_db_view.asp">View the Table</a>


</BODY>

</HTML>

krisbrixon · Nov 6, 2002

Try something closer to this:

strConnect = "...connection string..."
Set objConn = Server.CreateObject("ADODB.Connection&quot

objConn.Open strConnect
strSQL = "INSERT INTO tblTable1 (decValue1) VALUES (3.4)"
objConn.Execute(strSQL)
objConn.Close
Set objConn = Nothing

Kris
- The only program that runs perfectly every time, is a virus

neillovell · Nov 6, 2002

I'll give it a try

The problem is centred around
<%
accessdb="TempASPLink"
cn="DRIVER={Microsoft Access Driver (*.mdb)};"
cn=cn & "DBQ=" & server.mappath(accessdb)
set rs = server.createobject("ADODB.Recordset&quot

SQL = "insert into testtable (lname, fname) "

SQL = SQL & "values ('" & u_lname
SQL = SQL & "','" & u_fname & "')"

rs.Open sql, cn // HERE!!!!!!!!!!!!!!!!!!!!!
%>

I believe, but I'll have a go with yours.

onpnt · Nov 6, 2002

you need the ext. on the DB
accessdb="TempASPLink.mdb" A language that doesn't affect the way you think about programming is not worth knowing.

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

neillovell · Nov 6, 2002

Here's where the code was from

http://www.codeave.com/asp/code.asp?u_log=58

adding .mdb doesn't work - I don't need it I reckon because the third page which displays the data doesn't use it.

I can connect to the database using the third file -

<%
accessdb="TempASPLink"
cn="DRIVER={Microsoft Access Driver (*.mdb)};"
cn=cn & "DBQ=" & server.mappath(accessdb)
Set rs = Server.CreateObject("ADODB.Recordset&quot

sql = "select * from testtable"

rs.Open sql, cn
%>

// do display work

rs.Open sql, cn works here, but not for inputting data.

onpnt · Nov 6, 2002

I'll take a look at it in a minute but the .mdb does and should be there. don't get in the habit of coing the wrong way.

take a few minutes and read this

http://2fix.bvu.edu/policies/appstd.doc

A language that doesn't affect the way you think about programming is not worth knowing.

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

neillovell · Nov 6, 2002

I don't need a query to be present in the database for this to work do I?

onpnt · Nov 6, 2002

try some debug steps.
first the problem is either in your connection string or the sql statement. So
write the SQL var to the screen and see if it actual looks the way it should
Response.Write SQL
second
dot he same with the connection string
Response.Write cn

A language that doesn't affect the way you think about programming is not worth knowing.

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

onpnt · Nov 6, 2002

try this and see if ti works
<HTML>

<HEAD>
<TITLE>Text to Database</TITLE>
</HEAD>

<BODY>

<%
firstname=request.form("firstname&quot

lastname=request.form("lastname&quot

' test the values
' response.write firstname & " " & lastname
%>

<%
accessdb="TempASPLink.mdb"
cn = "DRIVER={Microsoft Access Driver (*.mdb)};DBQ=" & Server.MapPath("accessdb&quot

& ";"
set rs = Server.CreateObject("ADODB.Recordset&quot

sql = "INSERT INTO testtable (lastname, firstname) "
sql = sql & "values ('" & firstname
sql = sql & "','" & lastname & "')"
' test response.write sql
rs.Open sql, cn
%>

First Name <%= firstname %>
 
Last Name <%= lastname %>
 
has been added to the db 
<a href = "input_text_db_view.asp">View the Table</a>


</BODY>

</HTML>

take out the commented ares to test. there is no reason for you to concatinate your connection string. it's short and simple so there is no need to give it the oppurtunity for errors to occur A language that doesn't affect the way you think about programming is not worth knowing.

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

onpnt · Nov 6, 2002

apoogies I meant this line to be
get rid of the variable accessdb

cn = "DRIVER={Microsoft Access Driver (*.mdb)};DBQ=" & Server.MapPath("TempASPLink.mdb&quot

& ";" A language that doesn't affect the way you think about programming is not worth knowing.

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

onpnt · Nov 6, 2002

other things to look at

is the write permmisions set to the directory the DB is placed in?

open the connection for read/write like this also
rs.Open sql, cn,3,3
A language that doesn't affect the way you think about programming is not worth knowing.

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

neillovell · Nov 6, 2002

I've got [Microsoft][ODBC Microsoft Access Driver] Operation must use an updateable query.

I'm using your rs.Open sql, cn,3,3 code at the bottom. Testing SQL and the data they both have the expected output.

onpnt · Nov 6, 2002

that leads me to believe the write permissions are incorrect or not set on the directory the DB is located.

have they been set.
how are you testing this? A language that doesn't affect the way you think about programming is not worth knowing.

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

neillovell · Nov 6, 2002

you would be right!
I right-clicked on the file, selected EVERYONE under permissions and checked the WRITE box. I don't know if this compromises our intranet's security but this will do for now.

Here is the code at the moment - am going to try to rewrite so it doesn't use rs.Open but a connection object.

<HTML>

<HEAD>
<TITLE>Text to Database</TITLE>
</HEAD>

<BODY>

<%
firstname=request.form("u_fname&quot

lastname=request.form("u_lname&quot

' test the values
response.write firstname & " " & lastname
%>

<%
accessdb="TempASPLink.mdb"

cn = "DRIVER={Microsoft Access Driver (*.mdb)};DBQ=" & Server.MapPath("TempASPLink.mdb&quot

& ";"
set rs = Server.CreateObject("ADODB.Recordset&quot

sql = "INSERT INTO testtable (lname, fname) "
sql = sql & "values ('" & firstname
sql = sql & "','" & lastname & "')"
' test response.write sql
response.write sql
rs.Open sql, cn,3,3
%>

First Name <%= firstname %>
 
Last Name <%= lastname %>
 
has been added to the db 
<a href = "input_text_db_view.asp">View the Table</a>


</BODY>

</HTML>

neillovell · Nov 6, 2002

Many many thanks again!

onpnt · Nov 6, 2002

should not have to worry about your intranet's security with this. don't take me up on that one though. [lol]

glad you got it A language that doesn't affect the way you think about programming is not worth knowing.

http://www.onpntwebdesigns.com

admin@onpntwebdesigns.com

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Why is this code not working? (From a site) 2

neillovell

Programmer

krisbrixon

Programmer

neillovell

Programmer

onpnt

Programmer

neillovell

Programmer

onpnt

Programmer

neillovell

Programmer

onpnt

Programmer

onpnt

Programmer

onpnt

Programmer

onpnt

Programmer

neillovell

Programmer

onpnt

Programmer

neillovell

Programmer

neillovell

Programmer

onpnt

Programmer

Similar threads

Part and Inventory Search

Sponsor