Vbscript functions (help!!) 1

boab · May 30, 2001

Hi guys have a bit of a problem. I'm currently working on a website using asp to generate page on the fly however the functions whichI am using in vbscript will not work. The error message that is being returned is that the server was expecting the 'End' statement however the 'End Function' statement is already there. Predictably enough when I remove the word function the error is that the word function was expected, any Ideas? thanx

Mighty · May 30, 2001

can you please post the function code. Mise Le Meas,

Mighty

boab · May 30, 2001

Hi here is the source code the reason that I did it this way is that it was the easiest way I could think of to populate the text field if there was an error in the registration if there is a more elegeant way of doing this (and one that requires less typing!!) I would be grateful.

<%Language vbscript%>
<%
dim usr, name1, name2, add1, add2, post, email, Pass1, pass2,init
dim alerter
set usr =request("usr&quot

set name1 = request("name1&quot

set name2 = request("name2&quot

set add1 = request("addr1&quot

set add2 = request("addr2&quot

set post = request("post&quot

set email = request("email&quot

set pass1 = request("pass1&quot

set pass2 = request("pass2&quot

set init= request("initials&quot

dim con, rst, sql
set sql = "Select * From PublicMembers WHERE usr="&usr
set con = Server.CreateObject("ADODB.Connection&quot

call con.open("COED_DSN","BoabFett","noddy1&quot

set rst = Server.CreateObject("ADODB.Recordset&quot

If (eChk(email)<>1)Then
set alerter = emal
alerter(alerter)
else if((pass1<>pass2)Or(pass1="&quot

) Then
set alerter = pas
alerter(alerter)
else
call rst.open(sql, con,adOpenStatic, adLockOptomistic, adCmdText)
dim chqkr
set chqkr=rst("name1&quot

If(chqkr=null)Then
Call rst.AddNew()
rst("usr&quot

=usr
rst("nam1&quot

=name1
rst("nam2&quot

=name2
rst("init&quot

=init
rst("addr1&quot

=add1
rst("addr2&quot

=add2
rst("post&quot

=post
rst("email&quot

=email
rst("pass&quot

=pass1
Call rst.Update()
Call rst.MoveLast()
else
set alerter = userr
alerter(alerter)

Function Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
response.write("<html>&quot

response.write("<head>&quot

response.write("<title>Untitled Document</title>&quot

response.write(" <meta http-equiv="" &"Content-Type"" &" content="" &"text/html; charset=iso-8859-1"" &">&quot

response.write("</head>&quot

response.write(" <body bgcolor="" &"#000099"" &" text="" &"#00CCFF"" & "background="" &"../1163k5Edinburgh.gif"" &">&quot

response.write(" <div align=" center ">&quot

response.write(" <p><font size=" 5 " ><b><u><i><font size=" 7 " >C</font></i>ity of <i> <font size=" 7 ">E</font></i>dinburgh &quot

response.write(" <i><font size=" & 7 ">M</font></i>essage <font size=" 7 "> <i>B</i></font>oard <i><font size= " 7 ">R</font></i>egistration &quot

response.write(" </u></b></font></p>&quot

response.write(" <form name=" form1 " method=" post " action= " regcheck.asp " >&quot

response.write(" <table width="" &"50%"" &" border="" &"0"" &">&quot

response.write(" <tr>&quot

response.write(" <td width='32%'>User Name</td>&quot

response.write(" <td width='68%'>&quot

response.write(" <input type="" &"text"" &" name="" &"usr"" &" value=" & usr &">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">First Name</td>&quot

response.write(" <td width="" &"68%"" &"> &quot

response.write(" <input type="" &"text"" &" name="" &"name1"" &" value="& name1 &">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">Initials</td>&quot

response.write(" <td width="" &"68%"" &"> &quot

response.write(" <input type="" &"text"" &" name="" &"inits"" &" value=>&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">Second Name</td>&quot

response.write(" <td width="" &"68%"" &"> &quot

response.write(" <input type="" &"text"" &" name="" &"name2"" &" value=" &name2&">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">Address 1</td>&quot

response.write(" <td width="" &"68%"" &"> &quot

response.write(" <input type="" &"text"" &" name="" &"addr1"" &" value="&add1&">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">Address 2</td>&quot

response.write(" <td width="" &"68%"" &"> &quot

response.write(" <input type=" text " name=" addr2 quot value=" add2 ">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">Post/Zip Code</td>&quot

response.write(" <td width="" &"68%"" &"> &quot

response.write(" <input type="" &"text"" &" name="" &"postcd"" &" value="&post&">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">E-mail</td>&quot

response.write(" <td width="" &"68%"" &"> &quot

response.write(" <input type="" &"text"" &" name="" &"email"" &" value="&email&">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">PassWord</td>&quot

response.write(" <td width=""68%"" &"> &quot

response.write(" <input type="" &"text"" &" name="" &"pass1"" &"value="&pass1&">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" <tr>&quot

response.write(" <td width="" &"32%"" &">Confirm Password</td>&quot

response.write(" <td width="" &"68%"" &"> &quot

response.write(" <input type="" &"text"" &" name="" &"pass2"" &"value="&pass2&">&quot

response.write(" </td>&quot

response.write(" </tr>&quot

response.write(" </table>&quot

response.write(" </form>&quot

response.write(" </div>&quot

response.write("</body>&quot

response.write("</html>&quot

End Function

%>

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<script language="javascript">
<!--

function alerter(val)
if (val='emal'){
alert("Sorry the email address you entered is not valid&quot

;
email="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}
else if(val='pas'){
alert("Sorry but the two passwords you entered do not match&quot

;
pass1="";
pass2="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}else {
alert("Sorry but the User name you have choosen is already taken please choose another&quot

;
usr="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}
}
function eChk(email) {
var L = email.length;
for(var i=0;i<=L;i++){
if(email.charAt(i)=='@') {
var dot1 = email.charAt(email.length-6)
var dot2 = email.charAt(email.length-4)
if (dot1=='.') {
var sub1 = email.substring(email.length-6,email.length)
if (sub1=='co.uk') {
return 1;
break;
} else {
return 0;
break;
}

}else if(dot2='.'){
var sub2 =email.substring(email.length-4,email.length)
if((sub1=='com')||(sub1=='org')||(sub1=='net')) {
return 1;
break;
}else{
return 0;
break;
}
}
}else{
return 0;
break;
}
}

}

-->
</script>

</head>

<body bgcolor="#FFFFFF" text="#000000">

</body>
</html>

Mighty · May 31, 2001

It looks like maybe the system thinks your "End Function" is just part of your final Response.Write. I've seen this myself a couple of times. What I would do is go to the end of the last response.write statement and hit enter. Hopefully, this might work. Mise Le Meas,

Mighty

boab · May 31, 2001

I have tried that and just get the same response

Mighty · May 31, 2001

I'm grasping at straws here but try leaving out the parentheses on the response.write statements. I personnally never use parentheses. (you must leave a space between the write and the operning quotes)
i.e.

Function Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
response.write "<html>"
response.write "<head>"
.
.
.
response.write "</body>"
response.write "</html>"
End Function

Mise Le Meas,

Mighty

boab · May 31, 2001

The page now reads

<%Language vbscript%>
<%
dim usr, name1, name2, add1, add2, post, email, Pass1, pass2,init
dim alerter
set usr =request("usr&quot

set name1 = request("name1&quot

set name2 = request("name2&quot

set add1 = request("addr1&quot

set add2 = request("addr2&quot

set post = request("post&quot

set email = request("email&quot

set pass1 = request("pass1&quot

set pass2 = request("pass2&quot

set init= request("initials&quot

dim con, rst, sql
set sql = "Select * From PublicMembers WHERE usr="&usr
set con = Server.CreateObject("ADODB.Connection&quot

call con.open("COED_DSN","BoabFett","noddy1&quot

set rst = Server.CreateObject("ADODB.Recordset&quot

If (eChk(email)<>1)Then
set alerter = emal
alerter(alerter)
else if((pass1<>pass2)Or(pass1="&quot

) Then
set alerter = pas
alerter(alerter)
else
call rst.open(sql, con,adOpenStatic, adLockOptomistic, adCmdText)
dim chqkr
set chqkr=rst("name1&quot

If(chqkr=null)Then
Call rst.AddNew()
rst("usr&quot

=usr
rst("nam1&quot

=name1
rst("nam2&quot

=name2
rst("init&quot

=init
rst("addr1&quot

=add1
rst("addr2&quot

=add2
rst("post&quot

=post
rst("email&quot

=email
rst("pass&quot

=pass1
Call rst.Update()
Call rst.MoveLast()
else
set alerter = userr
alerter(alerter)

Function Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
response.write "<html>"
response.write "<head>"
response.write "<title>Untitled Document</title>"
response.write " <meta http-equiv="&quot &"Content-Type"&quot &" content="&quot &"text/html; charset=iso-8859-1"&quot &">"
response.write "</head>"

response.write " <body bgcolor="&quot &"#000099"&quot &" text="&quot &"#00CCFF"&quot & "background="&quot &"../1163k5Edinburgh.gif"&quot &">"
response.write " <div align=&quot center &quot>"
response.write " <p><font size=&quot 5 &quot ><b><u><i><font size=&quot 7 &quot >C</font></i>ity of <i> <font size=&quot 7 &quot>E</font></i>dinburgh "
response.write " <i><font size=&quot & 7 &quot>M</font></i>essage <font size=&quot 7 &quot> <i>B</i></font>oard <i><font size= &quot 7 &quot>R</font></i>egistration "
response.write " </u></b></font></p>"
response.write " <form name=&quot form1 &quot method=&quot post &quot action= &quot regcheck.asp &quot >"
response.write " <table width="&quot &"50%"&quot &" border="&quot &"0"&quot &">"
response.write " <tr>"
response.write " <td width='32%'>User Name</td>"
response.write " <td width='68%'>"
response.write " <input type="&quot &"text"&quot &" name="&quot &"usr"&quot &" value=" & usr &">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">First Name</td>"
response.write " <td width="&quot &"68%"&quot &"> "
response.write " <input type="&quot &"text"&quot &" name="&quot &"name1"&quot &" value="& name1 &">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">Initials</td>"
response.write " <td width="&quot &"68%"&quot &"> "
response.write " <input type="&quot &"text"&quot &" name="&quot &"inits"&quot &" value=>"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">Second Name</td>"
response.write " <td width="&quot &"68%"&quot &"> "
response.write " <input type="&quot &"text"&quot &" name="&quot &"name2"&quot &" value=" &name2&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">Address 1</td>"
response.write " <td width="&quot &"68%"&quot &"> "
response.write " <input type="&quot &"text"&quot &" name="&quot &"addr1"&quot &" value="&add1&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">Address 2</td>"
response.write " <td width="&quot &"68%"&quot &"> "
response.write " <input type=&quot text &quot name=&quot addr2 quot value=&quot add2 &quot>"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">Post/Zip Code</td>"
response.write " <td width="&quot &"68%"&quot &"> "
response.write " <input type="&quot &"text"&quot &" name="&quot &"postcd"&quot &" value="&post&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">E-mail</td>"
response.write " <td width="&quot &"68%"&quot &"> "
response.write " <input type="&quot &"text"&quot &" name="&quot &"email"&quot &" value="&email&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">PassWord</td>"
response.write " <td width=""68%"&quot &"> "
response.write " <input type="&quot &"text"&quot &" name="&quot &"pass1"&quot &"value="&pass1&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="&quot &"32%"&quot &">Confirm Password</td>"
response.write " <td width="&quot &"68%"&quot &"> "
response.write " <input type="&quot &"text"&quot &" name="&quot &"pass2"&quot &"value="&pass2&">"
response.write " </td>"
response.write " </tr>"
response.write " </table>"
response.write " </form>"
response.write " </div>"
response.write "</body>"
response.write "</html>"
End Function

%>

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<script language="javascript">
<!--

function alerter(val)
if (val='emal'){
alert("Sorry the email address you entered is not valid&quot

;
email="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}
else if(val='pas'){
alert("Sorry but the two passwords you entered do not match&quot

;
pass1="";
pass2="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}else {
alert("Sorry but the User name you have choosen is already taken please choose another&quot

;
usr="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}
}
function eChk(email) {
var L = email.length;
for(var i=0;i<=L;i++){
if(email.charAt(i)=='@') {
var dot1 = email.charAt(email.length-6)
var dot2 = email.charAt(email.length-4)
if (dot1=='.') {
var sub1 = email.substring(email.length-6,email.length)
if (sub1=='co.uk') {
return 1;
break;
} else {
return 0;
break;
}

}else if(dot2='.'){
var sub2 =email.substring(email.length-4,email.length)
if((sub1=='com')||(sub1=='org')||(sub1=='net')) {
return 1;
break;
}else{
return 0;
break;
}
}
}else{
return 0;
break;
}
}

}

-->
</script>

</head>

<body bgcolor="#FFFFFF" text="#000000">

</body>
</html>

and I am still getting the same message from the server could this be a problem with the server I am running pws4 on win 98 this is driving me X-)(nuts)

Palooka · May 31, 2001

It seems to me that you have forgot to end two of your If-statements. Above

Code:

Function Renter

, add the following:

Code:

     End If
  End If

That will close the statments:

Code:

     If (eChk(email)<>1)Then

and

Code:

     If(chqkr=null)Then

Hope this helps,
Palooka

Guest_imported · May 31, 2001

It appears you are missing the "End If" just before the function.

Fengshui_1998

JohnYingling · May 31, 2001

Has anybody noticed that he uses
else if
instead of elseif

Code:

If ......
else if .....
else 
should be
if ..........
else
    if ..........
    else .....
    end if
End if
OR
If .....
elseif .....
else ......
endif

http://WWW.VBCompare.Com

boab · May 31, 2001

Right Guys I have added the endif s(I feel so stupid about that

) and the code reads:
<%Language vbscript%>
<%
dim usr, name1, name2, add1, add2, post, email, Pass1, pass2,init
dim alerter
set usr =request("usr&quot

set name1 = request("name1&quot

set name2 = request("name2&quot

set add1 = request("addr1&quot

set add2 = request("addr2&quot

set post = request("post&quot

set email = request("email&quot

set pass1 = request("pass1&quot

set pass2 = request("pass2&quot

set init= request("initials&quot

dim con, rst, sql
set sql = "Select * From PublicMembers WHERE usr="&usr
set con = Server.CreateObject("ADODB.Connection&quot

call con.open("COED_DSN","BoabFett","noddy1&quot

set rst = Server.CreateObject("ADODB.Recordset&quot

If (eChk(email)<>1)Then
set alerter = emal
alerter(alerter)
else if((pass1<>pass2)Or(pass1="&quot

) Then
set alerter = pas
alerter(alerter)
else
call rst.open(sql, con,adOpenStatic, adLockOptomistic, adCmdText)
dim chqkr
set chqkr=rst("name1&quot

If(chqkr=null)Then
Call rst.AddNew()
rst("usr&quot

=usr
rst("nam1&quot

=name1
rst("nam2&quot

=name2
rst("init&quot

=init
rst("addr1&quot

=add1
rst("addr2&quot

=add2
rst("post&quot

=post
rst("email&quot

=email
rst("pass&quot

=pass1
Call rst.Update()
Call rst.MoveLast()
else
set alerter = userr
alerter(alerter)
End If
End If

Function Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
response.write "<html>"
response.write "<head>"
response.write "<title>Untitled Document</title>"
response.write " <meta http-equiv="" &"Content-Type"" &" content="" &"text/html; charset=iso-8859-1"" &">"
response.write "</head>"

response.write " <body bgcolor="" &"#000099"" &" text="" &"#00CCFF"" & "background="" &"../1163k5Edinburgh.gif"" &">"
response.write " <div align=" center ">"
response.write " <p><font size=" 5 " ><b><u><i><font size=" 7 " >C</font></i>ity of <i> <font size=" 7 ">E</font></i>dinburgh "
response.write " <i><font size=" & 7 ">M</font></i>essage <font size=" 7 "> <i>B</i></font>oard <i><font size= " 7 ">R</font></i>egistration "
response.write " </u></b></font></p>"
response.write " <form name=" form1 " method=" post " action= " regcheck.asp " >"
response.write " <table width="" &"50%"" &" border="" &"0"" &">"
response.write " <tr>"
response.write " <td width='32%'>User Name</td>"
response.write " <td width='68%'>"
response.write " <input type="" &"text"" &" name="" &"usr"" &" value=" & usr &">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">First Name</td>"
response.write " <td width="" &"68%"" &"> "
response.write " <input type="" &"text"" &" name="" &"name1"" &" value="& name1 &">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">Initials</td>"
response.write " <td width="" &"68%"" &"> "
response.write " <input type="" &"text"" &" name="" &"inits"" &" value=>"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">Second Name</td>"
response.write " <td width="" &"68%"" &"> "
response.write " <input type="" &"text"" &" name="" &"name2"" &" value=" &name2&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">Address 1</td>"
response.write " <td width="" &"68%"" &"> "
response.write " <input type="" &"text"" &" name="" &"addr1"" &" value="&add1&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">Address 2</td>"
response.write " <td width="" &"68%"" &"> "
response.write " <input type=" text " name=" addr2 quot value=" add2 ">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">Post/Zip Code</td>"
response.write " <td width="" &"68%"" &"> "
response.write " <input type="" &"text"" &" name="" &"postcd"" &" value="&post&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">E-mail</td>"
response.write " <td width="" &"68%"" &"> "
response.write " <input type="" &"text"" &" name="" &"email"" &" value="&email&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">PassWord</td>"
response.write " <td width=""68%"" &"> "
response.write " <input type="" &"text"" &" name="" &"pass1"" &"value="&pass1&">"
response.write " </td>"
response.write " </tr>"
response.write " <tr>"
response.write " <td width="" &"32%"" &">Confirm Password</td>"
response.write " <td width="" &"68%"" &"> "
response.write " <input type="" &"text"" &" name="" &"pass2"" &"value="&pass2&">"
response.write " </td>"
response.write " </tr>"
response.write " </table>"
response.write " </form>"
response.write " </div>"
response.write "</body>"
response.write "</html>"
EndFunction

%>

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<script language="javascript">
<!--

function alerter(val)
if (val='emal'){
alert("Sorry the email address you entered is not valid&quot

;
email="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}
else if(val='pas'){
alert("Sorry but the two passwords you entered do not match&quot

;
pass1="";
pass2="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}else {
alert("Sorry but the User name you have choosen is already taken please choose another&quot

;
usr="";
Renter(usr, name1, name2, add1, add2, post, email, Pass1, pass2)
}
}
function eChk(email) {
var L = email.length;
for(var i=0;i<=L;i++){
if(email.charAt(i)=='@') {
var dot1 = email.charAt(email.length-6)
var dot2 = email.charAt(email.length-4)
if (dot1=='.') {
var sub1 = email.substring(email.length-6,email.length)
if (sub1=='co.uk') {
return 1;
break;
} else {
return 0;
break;
}

}else if(dot2='.'){
var sub2 =email.substring(email.length-4,email.length)
if((sub1=='com')||(sub1=='org')||(sub1=='net')) {
return 1;
break;
}else{
return 0;
break;
}
}
}else{
return 0;
break;
}
}

}

-->
</script>

</head>

<body bgcolor="#FFFFFF" text="#000000">

</body>
</html>
but I still get the error as below

Microsoft VBScript compilation error '800a03f6'

Expected 'End'

/sgcpb/Members/regcheck.asp, line 135

Palooka · Jun 1, 2001

That's probably because of the reason JohnYingling mentioned above.

Use

Code:

ElseIf

instead of

Code:

Else If

/Palooka

boab · Jun 1, 2001

done that & now I'm getting the message below

Microsoft VBScript compilation error '800a0400'

Expected statement

/sgcpb/Members/regcheck.asp, line 49

EndIf
^

Also I have another thread under the title of String variants Can some body have a look at it please

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Vbscript functions (help!!) 1

boab

Programmer

Mighty

Programmer

boab

Programmer

Mighty

Programmer

boab

Programmer

Mighty

Programmer

boab

Programmer

Palooka

Programmer

Guest_imported

New member

JohnYingling

Programmer

boab

Programmer

Palooka

Programmer

boab

Programmer

Similar threads

Part and Inventory Search

Sponsor