vbs logon script help needed!!

[maclp]

hello,

i'm in need of help with my vbscript.

i want to use it to map a drive to the users in a curtain group in AD by implementing it in group policy.

however i'm not sure if it works correctly.

the script:
On Error Resume Next

Set objSysInfo = CreateObject("ADSystemInfo")
Set objNetwork = CreateObject("Wscript.Network")

strUserPath = "LDAP://" & objSysInfo.UserName
Set objUser = GetObject(strUserPath)

For Each strGroup in objUser.MemberOf
strGroupPath = "LDAP://" & strGroup
Set objGroup = GetObject(strGroupPath)
strGroupName = objGroup.CN

Select Case strGroupName
Case "testgroep"
objNetwork.MapNetworkDrive "R:", "\\TOM-TELLIE\SOFTLIB"

End Select
Next




can any of you see what's wrong with it.
thanks

 

[mrmovie]

you dont need to bind to each group that the user is a memberof, why bother? you are mapping drives based on group names, you can get the group name from the

For Each strGroup in objUser.MemberOf
Wscript.Echo strGroup

you dont need the
'Set objGroup = GetObject(strGroupPath)
'strGroupName = objGroup.CN

comment out On Error Resume Next, and put in some Wscript.Echo's at key points in your script with key data being echo's otthe screen, you will soon see where you are going wrong.

 

[maclp]

thanks for your reply!

so my script now looks like this:

'On Error Resume Next

Set objSysInfo = CreateObject("ADSystemInfo")
Set objNetwork = CreateObject("Wscript.Network")

strUserPath = "LDAP://" & objSysInfo.UserName
Set objUser = GetObject(strUserPath)

For Each strGroup in objUser.MemberOf
strGroupPath = "LDAP://" & strGroup
Wscript.Echo strGroup

Select Case strGroupName
Case "testgroep"
objNetwork.MapNetworkDrive "R:", "\\TOM-TELLIE\SOFTLIB"

End Select
Next



is this correct?

 

[mrmovie]

does it work? i would say no, therefore, no it is not correct.

what do you get displayed from the Wscript.Echo strGroup?
Your Select Case statement uses strGroupName. this variable is blank i would suggest, change your select case to use the strGroup.
You dont need strGroupName or strGroupPath.
Try to always use Option Explicit.
The way you are mapping the drive is fine for the first time the logonscript runs, however, it might fail the second time, because the user already has the R drive mapped? or it may fail right away as the user already has the R drive mapped, and perhaps to the wrong place.
i would not recommend doing a remove mapped drive before the mapping, as then you would be unmapping and remapping at every logon which seems pointless, however, at the moment, given your limited scripting ability it may be the simplest approach.

 

[markdmac]

Check out my FAQ, it has all the code you need on the subject:

http://www.tek-tips.com/faqs.cfm?fid=5798

I hope that helps.

Regards,

Mark

Check out my scripting solutions at

http://www.thespidersparlor.com/vbscript

Work SMARTER not HARDER. The Spider's Parlor's Admin Script Pack is a collection of Administrative scripts designed to make IT Administration easier! Save time, get more work done, get the Admin Script Pack.