Validation of a data base field

[mal54]

Im having troble validating a data base field the field is a key field in MS Access This is the function I have highlighted the offending code can anyone help?

function insertEntry( byref conn )
dim InstrID
dim TypeId
dim txtTitle
dim txtEntryDate
dim txtPassword
dim FirstName
dim LastName
dim txtStreetAddress
dim txtSuburb
dim txtState
dim txtBusinessPhone
dim txtEmail
dim iLength
dim iRecordId
dim rs
dim aInstrID
dim Sql

' read parameters.

InstrID = request("InstrID&quot
TypeID = request("TypeID&quot
txtTitle = request("txtTitle&quot
txtPassword = request("txtPassword&quot
FirstName = request("FirstName&quot
LastName = request("LastName&quot
txtStreetAddress = request("txtStreetAddress&quot
txtSuburb = request("txtSuburb&quot
txtState = request("txtState&quot
txtBusinessPhone = request("txtBusinessPhone&quot
txtEmail = request("txtEmail&quot


' open recordset.

Sql = "select from Instructors InstrID"
Set conn = Session("Learner_Connection&quot
set rs = Server.CreateObject("ADODB.Recordset&quot
rs.Open "Instructors", conn, 2, 3

aInstrID = rs.fields("InstrID&quot.value

'check parameters.
if not rs.eof then
If aInstrID = InstrID Then
insertEntry = false
exit function
end if
end if


' create new recordset.

rs.AddNew
rs("InstrID&quot = InstrID
rs("TypeId&quot = TypeID
rs("txtTitle&quot = txtTitle
rs("txtEntryDate&quot =Now
rs("txtPassword&quot = txtPassword
rs("FirstName&quot = FirstName
rs("LastName&quot = LastName
rs("txtStreetAddress&quot = txtStreetAddress
rs("txtSuburb&quot = txtSuburb
rs("txtState&quot = txtState
rs("txtBusinessPhone&quot = txtBusinessPhone
rs("txtEmail&quot = txtEmail
rs.Update

' succeeded.
insertEntry = true

rs.Close
Set rs = Nothing
end function

 

[Jonax]

What you are doing here will eventually bring the server to it's knees, as you don't close and destroy the connection to the db, when you call exit function.

I don't see why you pass the connection to the function, as you later get it from a sessionvariable.

But to address your question:
You should be able to do something like the following:

strSQL = "SELECT * FROM Instructors I WHERE InstrId = " & InstrId
Set conn = Session("Learner_Connection") 
set rs = Server.CreateObject("ADODB.Recordset") 
rs.Open strSQL, conn, 1, 3 
If (rs.bof AND rs.eof) then 'No such ID
	rs.AddNew
	[...]
	rs.Update
	InsertEntry = TRUE
Else
	InsertEntry = FALSE
End if
rs.close
set rs = Nothing
conn.close
set conn = Nothing

By the way:
If you are getting the contents from formfields, you should use request.FORM as this is less heavy on the server + it closes a possible hole, enabling users to pass values into your code from querystring-parametres. This is not a bug - it's an undocumented feature...
;-)