Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in
  • Congratulations Mike Lewis on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

using a variable in href tag?

Status
Not open for further replies.
CADTenchy

CADTenchy

Technical User
Dec 12, 2007
237
GB
I use a browser based system of checking procedures, written in html and javascript.

I’m doing a new one where I have a few <select> tag options.
I want to use these with onchange functions, to build up a variable that contains a url, and use that variable in a link lower down the page.
I can do the onchange functions I’m sure, already using something like that, but I’m failing to get the link to work.

Done some googling and seemed to be straight forward, but the hits I found don’t seem to work for me.

Just to get going I had this on the head:
JavaScript: 
<script>
<!--
function Page(){
  location.href="[URL unfurl="true"]www.google.com";[/URL]
}
// -->
</script>

Then in my <body>

I have:
HTML: 
<td width="20"><a href="javascript:page()" target="new2" style=""><img src="Checking_Images/info_icon_red.jpg" border="0"></a></td>

All that happens is a blank tab opens, url is “about:blank”

I’m using firefox 13 on windows 7 64bit.

Where am I going wrong?


Steve (Delphi 2007 & XP)
 
Sort by date Sort by votes
javascript is case sensitive, "Page" and "page" are NOT interchangeable.

Chris.

Indifference will be the downfall of mankind, but who cares?
Time flies like an arrow, however, fruit flies like a banana.
Webmaster Forum
 
Upvote 0 Downvote
Oh and href is a attribute of an anchor opening tag NOT a tag itself.

Chris.

Indifference will be the downfall of mankind, but who cares?
Time flies like an arrow, however, fruit flies like a banana.
Webmaster Forum
 
Upvote 0 Downvote
The usage of the javascript: protocol is considered a bad practice. That is placing an href that's not really a valid location is never a good idea.

Other than that, the target attribute is messing with the JS in that it opens the new page, but prevents the JS from actually running, since the function does not exist in the new opened page, but in the originating page only, so it can't be accessed.

If you want to open a new page you'll need to do it from the Javascript code rather that on the link itself.


Code: 
[COLOR=#990000]<[/color]a href[COLOR=#990000]=[/color][COLOR=#FF0000]"#"[/color] onclick[COLOR=#990000]=[/color][COLOR=#FF0000]"return Page();"[/color][COLOR=#990000]><[/color]img src[COLOR=#990000]=[/color][COLOR=#FF0000]"Checking_Images/info_icon_red.jpg"[/color] border[COLOR=#990000]=[/color][COLOR=#FF0000]"0"[/color][COLOR=#990000]></[/color]a[COLOR=#990000]>[/color]
Code: 
[b][COLOR=#0000FF]function[/color][/b] [b][COLOR=#000000]Page[/color][/b][COLOR=#990000]()[/color][COLOR=#FF0000]{[/color]
  window[COLOR=#990000].[/color][b][COLOR=#000000]open[/color][/b][COLOR=#990000]([/color][COLOR=#FF0000]"www.google.com"[/color][COLOR=#990000],[/color][COLOR=#FF0000]"new2"[/color][COLOR=#990000]);[/color]
  return [red]false[/red];
[COLOR=#FF0000]}[/color]


----------------------------------
Phil AKA Vacunita
----------------------------------
Ignorance is not necessarily Bliss, case in point:
Unknown has caused an Unknown Error on Unknown and must be shutdown to prevent damage to Unknown.

Web & Tech
 
Upvote 0 Downvote
schoolboy error corrected, and anchor semantics noted, thanks.

Corrected case, still the same.

Steve (Delphi 2007 & XP)
 
Upvote 0 Downvote
ah vacunita you posted while I was replying.

That looks good. I'll try that right now thanks.
I was wondering after I posted if the target might be an issue.


Steve (Delphi 2007 & XP)
 
Upvote 0 Downvote
sorted. Many thanks Phil!

Steve (Delphi 2007 & XP)
 
Upvote 0 Downvote
Glad it worked for out.

----------------------------------
Phil AKA Vacunita
----------------------------------
Ignorance is not necessarily Bliss, case in point:
Unknown has caused an Unknown Error on Unknown and must be shutdown to prevent damage to Unknown.

Web & Tech
 
Upvote 0 Downvote
CADTenchy said:
schoolboy error corrected, and anchor semantics noted, thanks.
Click to expand...

Wow! I'm impressed :)

Usually when I correct things like that, some take umbrage at it as being a personal insult to their intelligence.

Which of course it is not intended as such. So thank you, for restoring the balance somewhat.


Chris.

Indifference will be the downfall of mankind, but who cares?
Time flies like an arrow, however, fruit flies like a banana.
Webmaster Forum
 
Upvote 0 Downvote
Wow! I'm impressed smile

Usually when I correct things like that, some take umbrage at it as being a personal insult to their intelligence.

Which of course it is not intended as such. So thank you, for restoring the balance somewhat.
Click to expand...

If I felt I was in the right I would argue to the death :)

However, what umbrage can I take from being accurately corrected? :)

Steve (Delphi 2007 & XP)
 
Upvote 0 Downvote
CADTenchy said:
However, what umbrage can I take from being accurately corrected?
Click to expand...
Oooh! you would be surprised (or maybe not) :)

Chris.

Indifference will be the downfall of mankind, but who cares?
Time flies like an arrow, however, fruit flies like a banana.
Webmaster Forum
 
Upvote 0 Downvote
I was on usenet, in unmoderated newsgroups.
I don't there is anything that could surprise or shock me any more [dazed]

Steve (Delphi 2007 & XP)
 
Upvote 0 Downvote
Status
Not open for further replies.

Similar threads

BobMe23
What new features have appeared in the latest versions of Java?
Replies
1
Views
107
feherke
feherke
Mike Lewis
  • Locked
  • Question
Anyone here got any experience of Grid.JS (a sortable Javascript grid) 1
Replies
5
Views
768
Mike Lewis
Mike Lewis
jomat
  • Locked
  • Question
JS to show the timer in html under title instead of in the status bar
Replies
2
Views
387
xwb
xwb
penguinspeaks
  • Locked
  • Question
How do I pass a classic asp variable to JS
Replies
1
Views
522
xwb
xwb
TheLazyPig
  • Locked
  • Question
Dropdown (option) using Anguarjs
Replies
0
Views
313
TheLazyPig
TheLazyPig

Part and Inventory Search

Sponsor

Back
Top