update syntax problem

[gokeeffe]

Greetings,

As you can see i'm an annoying newbie can anyone tell me

what is wrong with my code.

if ($j1 && $k1 && $l1 && $g1 && $h1 && $i1 && $a1)

{

// Insert Keys into table
$query = "UPDATE users SET contact_name = '$j1'
landline = '$k1'
mobile = '$l1'
county_id = '$g1'
town_region_name = '$h1'
extra_location_details = '$i1'
WHERE user_id = '$a1'";
$result = @mysql_query ($query); // Run the query

Tks in advance

Gaz

 

[gokeeffe]

I forgot to insert the commas but it still doesn't work

if ($j1 && $k1 && $l1 && $g1 && $h1 && $i1 && $a1)

{

// Insert Keys into table
$query = "UPDATE users SET contact_name = '$j1',
landline = '$k1',
mobile = '$l1',
county_id = '$g1',
town_region_name = '$h1',
extra_location_details = '$i1',
WHERE user_id = '$a1'";
$result = @mysql_query ($query); // Run the query

 

[ericbrunson]

If you print the SQL after you create it and before you run it, does it look correct? Does it run when you past it into a mysql shell? Does the code even get there, since you include the "if" statement surrounding it?

 

[dalchri]

You'll need a comma after each field you are updating:

UPDATE users 
SET 
   contact_name = '$j1',
   landline     = '$k1',
   mobile       = '$l1',
   county_id     = '$g1',
   town_region_name = '$h1',
   extra_location_details = '$i1'
WHERE user_id  = '$a1'

Be certain that there are no single quotes embedded in any of these fields. For example, if extra_location_details turns out to be "Make a left after George's restaurant". You'll have a problem with your query. You'd need to code the string constant as "Make a left after George\'s restaurant" if I remember right.

 

[gokeeffe]

Tks dalchri

I had a comma after the '$il'

It now works perfectly

Tks for your help

Slainte (Irish for see ya)

 

[dalchri]

Oh, well in that case, may certain that no one enters a contact like "O'Brian"