Unterminated string constant: advise please 1

[SteveHigh]

Hello

I am getting an error message in a page which is supposed to show records in a table:

Microsoft VBScript compilation error '800a0409'

Unterminated string constant

/w3Test/addShow.asp, line 37

Response.Write("<tr><td>Full Name</td></td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr>
-----------------------------------------------------------------------------------------------------------------^

The code I have is:

Response.Write("<tr><td>Full Name</td></td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr>

Response.Write("<tr><td>" & TBL("FullName") & "</td><td>" & TBL("Sex") & "</td><td>" & TBL("Country") & "</td><td>" & TBL("Hobbies") & "</td><td>" & TBL("FavouritePerson") & "</td></tr>")

Thanks for any suggestions or ideas.

Cheers

Steve

 

[MoLaker]

You included the following code:
Response.Write("<tr><td>Full Name</td></td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr> which should be more like Response.Write("<tr><td>Full Name</td></td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr>"). You've left off the closing quotes. However, since your error message points to a location that doesn't make a lot of sense, it may be you have left out some quotes before this or added some inappropriately. Fix the problem above then try again. You may find your error is flagged at another location.

 

[xwb]

You don't have to stick everything on one line. You can split it over several lines using _ to indicate continuation

Response.Write("<tr><td>Full Name</td>" & _
   "<td>Sex</td>" & _ 
   "<td>Country</td>" & _
   "<td>Hobbies</td>" & _
   "<td>Favourite Person</td>" & _
   "</tr>").

It will also help you spot mistakes like <td>Full Name</td></td>Sex</td>

 

[SteveHigh]

That's great, you both. I keep forgetting about the & _.

I saw the table formatting error this morning and have corrected the missing ") so that now I am able to add records to the table:

http://stevehigham59.7host.com/w3Test/addShow.asp

Is there a way of having the table as follows and not as I have it at the moment:

Full Name Sex Country Hobbies Person

Person1 Male UK Football Rooney
Person2 Female USA Baseball Davies
Person3 Female India Men R.Ich
Person4 Male Belize Swimming Kylie

Many thanks again for your help.

Steve

 

[MoLaker]

Good catch, xwb

Steve, I'm assuming you have a Do While Loop to pull the records and the creation of the first row is within that loop.

Something like...
Response write "<table>"
Do While Not RS.EOF
Response.Write("<tr><td>Full Name</td><td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr>")
Response.Write("<tr><td>" & TBL("FullName") & "</td><td>" & TBL("Sex") & "</td><td>" & TBL("Country") & "</td><td>" & TBL("Hobbies") & "</td><td>" & TBL("FavouritePerson") & "</td></tr>")
RS.movenext
Loop
Response.write "</table>"

As your current table displays, the header row is repeated with each record.

You can place the first row outside the loop...

Response write "<table>"
Response.Write("<tr><td>Full Name</td><td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr>")
Do While Not RS.EOF
Response.Write("<tr><td>" & TBL("FullName") & "</td><td>" & TBL("Sex") & "</td><td>" & TBL("Country") & "</td><td>" & TBL("Hobbies") & "</td><td>" & TBL("FavouritePerson") & "</td></tr>")
RS.movenext
Loop
Response.write "</table>"

 

[SteveHigh]

Hello Molaker

Is this the While | MoveNext you mean? I have this:

<%
Dim DB, TBL
Set DB = Server.CreateObject("ADODB.Connection")
Set TBL = Server.CreateObject("ADODB.RecordSet")
DB.Mode = adModeReadWrite

DB.Open "driver={Microsoft Access Driver (*.mdb)};DBQ=D:\business\form.mdb;"

TBL.Open "Details" ,DB

Response.Write("<table border='1'>")
While NOT TBL.EOF

Response.Write("<tr><td>Full Name</td><td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr>")

Response.Write("<tr><td>" & TBL("FullName") & "</td><td>" & TBL("Sex") & "</td><td>" & TBL("Country") & "</td><td>" & TBL("Hobbies") & "</td><td>" & TBL("FavouritePerson") & "</td></tr>")

TBL.MoveNext
Wend
TBL.Close

Response.Write("<caption>Data entries</caption>")
Response.Write("</table>")
DB.Close
Set DB = Nothing
Set TBL = Nothing

%>


Yes, you're right. I do not want the header repeated every other row - looks silly.

Steve

 

[MoLaker]

Response.Write("<table border='1'>")
While NOT TBL.EOF

Response.Write("<tr><td>Full Name</td><td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr>")

Response.Write("<tr><td>" & TBL("FullName") & "</td><td>" & TBL("Sex") & "</td><td>" & TBL("Country") & "</td><td>" & TBL("Hobbies") & "</td><td>" & TBL("FavouritePerson") & "</td></tr>")

TBL.MoveNext
Wend
TBL.Close

Yes. Move the header line to before the While statement.

Response.Write("<table border='1'>")
Response.Write("<tr><td>Full Name</td><td>Sex</td><td>Country</td><td>Hobbies</td><td>Favourite Person</td></tr>")
While NOT TBL.EOF

Response.Write("<tr><td>" & TBL("FullName") & "</td><td>" & TBL("Sex") & "</td><td>" & TBL("Country") & "</td><td>" & TBL("Hobbies") & "</td><td>" & TBL("FavouritePerson") & "</td></tr>")

TBL.MoveNext
Wend
TBL.Close

 

[SteveHigh]

Hello Molaker

That's done it!!

I think you have ensured that the cycle involved in inserting the new record does not include the table cell headings, aren't you?

Your finished result is here:

http://stevehigham59.7host.com/w3Test/addShow.asp

Cheers

Steve