This should work

mrchaos70 · Apr 15, 2002

Ok this should work, Im teaching my self Perl and I can get chunks of code to work, BUT when I put it together it craps out on me. Can somebody tell me what is worng with this?

The problem is in the sub showOneRecord
When I rund that chunk of code by its self it works just right, but the second I add that code to the sub then it takes a crap on me. What am I missing?

CODE FOLLOWS

print "\nThis program writes to a flie,\n";
print "\nPress any key to continue...";
$anychar=<stdin>;

for(;

{

print"\n\t1. Add Record";

print"\n\t5. View All Records.";

print "\n\tWhat action do you want to perform?\n\t";
$answer = <STDIN>;
chomp($answer);
if($answer =~ /^1/i){
#add
print "\n\tOption 1.\n";
enterData();
last;
}
elsif($answer =~ /^5/i){
#view all
print "\n\tOption 5.\n";
showAll();
last;
}

else{
print "\n\tMust select a valid option.\n";
next;
}

}#end for

sub enterData {

#---------------Inputs user data into Vars

print "\nBuilding you into the data base...\n ";

print "\nEnter Your Name: ";
$namedata = <stdin>;
chomp($namedata);

print "\nEneter your Email address: ";
$emaildata =<stdin>;
chomp($emaildata);

print "\nEnter your Street Address: ";
$streetadd = <stdin>;
chomp($streetadd);

print "\nEnter your city: ";
$city = <stdin>;
chomp ($city);

print "\nEnter your State: ";
$state= <stdin>;
chomp($state);

print "\nEnter your zip code: ";
$zip = <stdin>;
chomp($zip);

}
#---------------------list all records

sub showOneRecord{

print "\n\nNow printing a list of all records";
print "\n\tPress any key to print";

$anychar=<stdin>;

open(RFH,"<basicdata.txt&quot

||die("File could not be opend: $!&quot

;
$count=0;
while(my $line= <RFH>)
{
print "$line\n";
$count++;
if($count%15==0)
{
print "Push any key to continue ";
$count=0;

}
}
close(RFH);

$anychar=<stdin>;

}

NEVERSLEEP · Apr 16, 2002

sub showOneRecord{
print "\n\nNow printing a list of all records";
print "\n\tPress any key to print";
$anychar=<stdin>;
open(RFH,"<basicdata.txt&quot

||die("File could not be opend: $!&quot

;
$count=0;
while(my $line= <RFH>)
{
print "$line\n";
$count++;
if($count%15==0)
{
print "Push any key to continue ";
$count=0;
}
}
close(RFH);
$anychar=<stdin>;
}

tips:
twice the line $anychar=<stdin>; ???
if($count%15==0) ????? if($count == 15) no?

or try to be more explict in the loop
here usig foreach istead of while
@storer = <RFH>
foreach $line (@storer) {
print "\n$line";
if ($count == 15) {
print "\nhit Enter to continu";
$thefakepauservar = <stdin>;
$count = 0;
}
count++;
}

place the count++ the last statement of your loop
in your example u say
$count = 0
#looping....
$count++ # now is 1
#check count

see u never checked if count was 0

someone knowledge ends were
someone else knowledge starts

mrchaos70 · Apr 16, 2002

Thanks, like I said im still kind of new to perl, I seem to be unable to get you code to work at all...is there something you are leaving out that you asumed I should know?

MikeLacey · Apr 17, 2002

hi MrChaos

Try it like this, you don't need to specify STDIN when you want input from the user and your menu structure was a bit iffy.

Mike

$|=1;

for(;

{

print"\n\t1. Add Record";
print"\n\t5. View All Records.";
print"\n\tQuit.";
print "\n\tWhat action do you want to perform?\n\t";
$answer = <>;
chomp($answer);
if($answer =~ /1/){
#add
print "\n\tOption 1.\n";
enterData();
}elsif($answer =~ /5/){
#view all
print "\n\tOption 5.\n";
showAll();
}elsif($answer =~ /[Qq]/){
#view all
exit 0;
}else{
print "$answer\n";
print "\n\tMust select a valid option.\n";
next;
}
}#end for

sub enterData {

#---------------Inputs user data into Vars

print "\nBuilding you into the data base...\n ";

print "\nEnter Your Name: ";
$namedata = <>;
chomp($namedata);

print "\nEneter your Email address: ";
$emaildata =<>;
chomp($emaildata);

print "\nEnter your Street Address: ";
$streetadd = <>;
chomp($streetadd);

print "\nEnter your city: ";
$city = <>;
chomp ($city);

print "\nEnter your State: ";
$state= <>;
chomp($state);

print "\nEnter your zip code: ";
$zip = <stdin>;
chomp($zip);
open(RFH,">>basicdata.txt&quot

||die("File could not be opend: $!&quot

;
print RFH "$namedata $emaildata $streetadd $city $state $zip\n";
close(RFH);

}
#---------------------list all records

sub showAll{

print "\n\nNow printing a list of all records";
print "\n\tPress any key to print";

$anychar=<>;

open(RFH,"<basicdata.txt&quot

||die("File could not be opend: $!&quot

;
$count=0;
while(my $line= <RFH>)
{
print "$line\n";
$count++;
if($count%15==0){
print "Push any key to continue ";
$count=0;
}
}
close(RFH);

$anychar=<>;

}
Mike
"Experience is the comb that Nature gives us after we are bald."

Is that a haiku?
I never could get the hang
of writing those things.

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

This should work

mrchaos70

Technical User

NEVERSLEEP

Programmer

mrchaos70

Technical User

MikeLacey

MIS

Similar threads

Part and Inventory Search

Sponsor