syntax error 1

[vttech]

I keep getting a syntax error on the code below.. Why?

Private Sub cmdSubmit_Click()

if (me!cboWorkDate.value = "" or me!txtLogIn.value = "" or
me!txtLogOut.value = "" or me!cboSite.value = "" or me!cboActivity.value = "") then
MsgBox NameOfField & " is a required field"
Else
InputLogInOut
End If

End Sub

Newbie in search of knowledge

 

[kjv1611]

Is this defined somewhere else?

InputLogInOut

 

[kjv1611]

But, your sytnax error is here:

if (me!cboWorkDate.value = "" or me!txtLogIn.value = "" or
me!txtLogOut.value = "" or me!cboSite.value = "" or me!cboActivity.value = "") then
MsgBox NameOfField & " is a required field"
Else
InputLogInOut
End If

Change to:

if (me!cboWorkDate.value = "" or me!txtLogIn.value = "" or [highlight]_[/highlight]
me!txtLogOut.value = "" or me!cboSite.value = "" or me!cboActivity.value = "") then
MsgBox NameOfField & " is a required field"
Else
InputLogInOut
End If

Assuming this is exactly how you have it in your code.

 

[vttech]

OK I see what you mean since the code spans several lines I need a _ to connect lines

Newbie in search of knowledge

 

[kjv1611]

Exactly.

 

[vttech]

dim FieldsRequired as string

I want to create a sub that checks the combo/text boxes on my form for values = ""
if so they would and that combo/text boxes name to FieldsRequired

Example:

Me!cboWorkDate.Value = ""
Me!txtLogin.Value = ""
Me!cboSite.Value = ""

then FieldsRequired would equal cboWorkDate.Name, txtLogin.Name, cboSite.Name

How would I go about creating this with VBA code??


Newbie in search of knowledge

 

[kjv1611]

Well, for the "" part, I would just use:

If IsNull(cboWorkDate) Then
   ~do whatever
End If

Or for setting a value to Null, you could use:

Private Sub Whatever()
  Other stuff
  
  Me!cboWorkDate = vbNullString
  Me!txtLogin = vbNullString
  Me!cboSite = vbNullString

  Other stuff

End Sub
[/code

 

[kjv1611]

Well, for the "" part, I would just use:

If IsNull(cboWorkDate) Then
   ~do whatever
End If

Or for setting a value to Null, you could use:

Private Sub Whatever()
  Other stuff
  
  Me!cboWorkDate = vbNullString
  Me!txtLogin = vbNullString
  Me!cboSite = vbNullString

  Other stuff

End Sub

 

[kjv1611]

I had a bad feeling about that - Internet Explorer messed up on me, and I ended up sending it twice (they are the same, except the formatting is 100% correct in second instance). - my posts.

 

[vttech]

So I would have to use an if statement to check to see if that field is Null and then add that name to RequiredField list… Seems like a lot of typing but if that’s the only way to gather the names of the text and combo boxes that are null.

dim RequiredField as string

If IsNull(cboWorkDate) Then
   RequiredField = cboWorkDate.Name &", "
End If

If IsNull(txtLogin) Then
   RequiredField = txtLogin.Name &", "
End If

If IsNull(cboSite) Then
   RequiredField = cboSite.Name &", "
End If

Newbie in search of knowledge

 

[kjv1611]

I would think that would be the best method. But, if you are checking all of your controls, you might could use a loop, moving through the controls - might be a little less typing:

Private Sub CheckForNulls()
  Dim ctl as Control
  For Each ctl in Form.Controls
    If TypeOf ctl Is ComboBox or TypeOf ctl Is TextBox _
    or TypeOf ctl Is ListBox Then
       If IsNull(ctl) Then
         'your code here for dealing with these
       Else
         'your code if any for dealing with non-null controls
       End If
    End If

[/code]

 

[MajP]

First of all there is a big difference between a null value and a null string, the two are not the same. A variant can be null a string can have a null string "". This is a better check

if trim(me.controlname & " ") = "" then

This handles a null value, a null string, an empty value, and spaces " ".
Second you could put "required" in the tag properties of the control

'untested
private function strRequired() as string 
  dim cntrl as access.control
  dim lenStrRequired as integer
  for each cntrl in me.controls
    if cntrl.tag = "required" then
       strRequired = strRequired & cntrl.name & ","
    end if
  next cntrl
  lenStrRequired = len(strRequired)
  if lenStrRequired>0 then
  strRequired = left(strRequired,lenStrRequired - 1)
end function

 

[kjv1611]

Another note you'll want to look at later:

In your form searchBOOKINGS, the procedure, Private Sub Search_Change() has a line, vSearchString = Search.Text.

That line is giving a compile error: method or data member not found..