Swaping image js help 2

[snowboardr]

I attempted to write a script to swap a plus / minus button based on what its src is... it was swaping it to minus, but its not swapping it back... but now its not doing anything ???
Any ideas... or can this be done this way?

ps. I am terrible at js.

<script type="text/javascript">
function SwapImage(imgid) {
if (document.getElementById(imgid).src == "images/forum/btns/plus_syn2.gif")
document.getElementById(imgid).src = "images/forum/btns/minus_syn2.gif";
}
Else
{
document.getElementById(imgid).src = "images/forum/btns/plus_syn2.gif";
}
</script>

Regards

 

[BillyRayPreachersSon]

You cannot check your src being exact to something unless you put in the full path to the image, for example:

if (img.src == 'images/someting.gif')

will never work, because as far as the browser is concerned, the real source is:

'[URL unfurl="true"]http://www.mysite.com/images/someting.gif'[/URL]

So you'll need to use "indexOf" to test for the src:

if (img.src.indexOf('images/someting.gif') != -1)

Hope this helps,
Dan



[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BillyRayPreachersSon]

Also, "Else" should have a lowercase "e" - JavaScript is case-sensitive.

Dan



[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[snowboardr]

It doesn't seem to be working...

<script type="text/javascript">
function SwapImage(imgid) {
If (document.getElementById(imgid).src.indexOf('images/forum/btns/plus_syn2.gif') == -1)
document.getElementById(imgid).src = "images/forum/btns/minus_syn2.gif";
}
else
{
document.getElementById(imgid).src = "images/forum/btns/plus_syn2.gif";
}
</script>

 

[BillyRayPreachersSon]

"If" should have a lowercase "i".

Dan



[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[snowboardr]

posted wrong code this is what i have..

<script type="text/javascript">
function SwapImage(imgid) {
If (document.getElementById(imgid).src.indexOf('images/forum/btns/plus_syn2.gif') != -1)
document.getElementById(imgid).src = "[URL unfurl="true"]http://localhost/0/images/forum/btns/minus_syn2.gif";[/URL]
}
else
{
document.getElementById(imgid).src = "[URL unfurl="true"]http://localhost/0/images/forum/btns/plus_syn2.gif";[/URL]
}
</script>

 

[BillyRayPreachersSon]

Which it did in your original code. Why change it?



[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BillyRayPreachersSon]

Also, you're missing an opening brace after the first if, and a closing brace for the function. Try this for size:

<script type="text/javascript">
function SwapImage(imgid) {
<!--
	var myImg = document.getElementById(imgid);
	if (myImg.src.indexOf('images/forum/btns/plus_syn2.gif') != -1) {
		myImg.src = '[URL unfurl="true"]http://localhost/0/images/forum/btns/minus_syn2.gif';[/URL]
	} else {
		myImg.src = '[URL unfurl="true"]http://localhost/0/images/forum/btns/plus_syn2.gif';[/URL]
	}
}
//-->
</script>

Hope this helps,
Dan



[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BabyJeffy]

As Dan was pointing out, you need to use a lower case "i" for the javascript operator "if":

<script type="text/javascript">
function SwapImage(imgid) {
[s]If[/s] [!]if[/!] (document.getElementById(imgid).src.indexOf('images/forum/btns/plus_syn2.gif') != -1)
...

Cheers,
Jeff

[tt]Jeff's Page @ Code Couch

http://www.codecouch.com/jeff/

http://www.codecouch.com/jeff/blog/

[/tt]

What is Javascript? FAQ216-6094

 

[snowboardr]

Thanks a ton guys. That code works like a charm.