Subscript out of range when populating an array 2

[brad1978]

Hi all,
Another quick question. I'm trying to populate 2 arrays from my SQL query and I keep getting the "Subscript out of range" error. Can someone explain what I'm doing wrong?

dim counter, prevComments(), R_to()
RS.movefirst 
counter = 0
	do until RS.EOF
		R_to(counter) = RS("R_postby")
		prevComments(counter) = RS("R_comments")
		counter = counter + 1 
RS.movenext
loop

Cheers!

 

[vicvirk]

In VBScript you cannot change the size of an array on the fly, so you'll need to either set it's size when you first declare it, or redim it each time you itterate through your array.

dim counter, prevComments(), R_to()
RS.movefirst 
counter = 0
    do until RS.EOF
		[b]redim R_to(counter)[/b]
		R_to(counter) = RS("R_postby")
		[b]redim prevComments(counter)[/b]
		prevComments(counter) = RS("R_comments")
        counter = counter + 1 
RS.movenext
loop

depending on how you open your recordset, you may be able to get the recordcount using rs.recordcount, if not you'll need to do a quick loop to find the number of records:

' start counting records
numRecords = rs.recordcount 
' if that doesn't work, the do it like this:
rs.movefirst
dim counter
numRecords = 0
do until rs.eof
	numRecords = numRecords + 1
loop
' end counting records

dim prevComments(numRecords)
dim R_to(numRecords)

RS.movefirst 
counter = 0
    do until RS.EOF
        R_to(counter) = RS("R_postby")
        prevComments(counter) = RS("R_comments")
        counter = counter + 1 
RS.movenext
loop

--------
GOOGLE is a great resource to find answers to questions like "how do i..."

If you don't know exaclty what you want to do or what to search on, try Google Suggest:

http://www.google.com/webhp?complete=1&hl=en

--------
I have recently been semi-converted to ensuring all my code (well most of it) works in both javascript and non-javasc

 

[trollacious]

Use

ReDim [b][red]Preserve[/red][/b] prevComments(counter)

so you don't erase the contents of the array each time you ReDim it.

Lee

 

[vicvirk]

good call lee - forgot about that

--------
GOOGLE is a great resource to find answers to questions like "how do i..."

If you don't know exaclty what you want to do or what to search on, try Google Suggest:

http://www.google.com/webhp?complete=1&hl=en

--------
I have recently been semi-converted to ensuring all my code (well most of it) works in both javascript and non-javasc

 

[wvdba]

you can also do a select count(somefield) to get number of records.

 

[brad1978]

Awesome, thanks for the help guys!!!
B