Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in
  • Congratulations Chris Miller on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

SSI call returning 1 4

Status
Not open for further replies.
audiopro

audiopro

Programmer
Apr 1, 2004
3,165
GB
I have this SSI call in an index page.
Code: 
<!--#include virtual="cgi-bin/picture.pl?call=body&amp;page=home&amp;" -->

It returns the index page's <body> via this print statement.

Code: 
	print "<body class='page_body' style='background-image: url(\"images/themes/halloween/homeback.jpg\");'>";

The body statement works fine but there is a stray '1' at the end of the <body> code and this appears at the top of the resulting page.
Is the problem because the script is not returning visible content or is there some other cause?

Keith
 
Sort by date Sort by votes
The problem was a sill schoolboy error.

Menu item .........
Code: 
#--------------------------------------------------------
if($INP eq 'body'){
#--------------------------------------------------------
	print &MakeBody();
	exit;
}

calling the sub ..........

Code: 
# --------------------------------------------------------
sub MakeBody{
# --------------------------------------------------------
	print "<body class='page_body' style='background-image: url(\"images/themes/halloween/homeback.jpg\");'>";
}

Doh!

Keith
 
Upvote 0 Downvote
Ah double print!

One in the routine, then the 'true' return value from sub.

Just a side note: It is apparently now bad practice to use ampersands for sub calls!

MakeBody();

instead of

&MakeBody();




"In complete darkness we are all the same, it is only our knowledge and wisdom that separates us, don't let your eyes deceive you."

"If a shortcut was meant to be easy, it wouldn't be a shortcut, it would be the way!"
Free Electronic Dance Music
 
Upvote 0 Downvote
Upvote 0 Downvote
I use the ampersand on sub calls for clarity and wonder what the issue is with them.

I did a quick search but couldn't find a specific reason not to use them.
Perhaps if I stopped using them, all my code would be perfect and I would never have to spend time looking for errors, ever again.

Keith
 
Upvote 0 Downvote
>> Perhaps if I stopped using them, all my code would be perfect and I would never have to spend time looking for errors, ever again.

Keith wake up - you appear to have nodded off and started dreaming! [sleeping2]

"In complete darkness we are all the same, it is only our knowledge and wisdom that separates us, don't let your eyes deceive you."

"If a shortcut was meant to be easy, it wouldn't be a shortcut, it would be the way!"
Free Electronic Dance Music
 
Upvote 0 Downvote
Hi

The best hint I found related to this is related to prototypes [sup](*)[/sup] :
man perlsub said:
The function declaration must be visible at compile time. The prototype affects only interpretation of new-style calls to the function, where new-style is defined as not using the & character. In other words, if you call it like a built-in function, then it behaves like a built-in function. If you call it like an old-fashioned subroutine, then it behaves like an old-fashioned subroutine.
Click to expand...
( man perlsub | Prototypes | 3[sup]rd[/sup] paragraph )

Personally I keep using the ampersand.

[small](*) The articles I read used various adjectives on them, usually somewhere between pointless and evil.[/small]


Feherke.
feherke.ga
 
Upvote 0 Downvote
Status
Not open for further replies.

Similar threads

ss_ham
  • Locked
  • Question
in Perl find call looking to exclude folder and ignore duplicate finds.
Replies
2
Views
255
ss_ham
ss_ham
Ahven
  • Locked
  • Question
Compiling Perl 5.36.0 fails on OS X 10.5.8 PowerPC
Replies
1
Views
170
mikrom
mikrom
Anurag Sinha
  • Locked
  • Question
calling perl script on click of the button
Replies
0
Views
165
Anurag Sinha
Anurag Sinha
ppeel
  • Locked
  • Question
sprintf() not returning expected result
Replies
4
Views
175
rharsh
rharsh
mlibeson
  • Locked
  • Question
Problem with fetchrow_array returning list instead of array (PERL,POSTGRES)
Replies
1
Views
97
mlibeson
mlibeson

Part and Inventory Search

Sponsor

Back
Top