Shortest code for mysql rows iteration 1

[Sleidia]

Here is the piece of code I use when I need to loop through several mysql rows (I use arrays just in case I have to do an improbable nested query) :

$sql_query[1] = "SELECT ____ ";
$sql_query[1] .= "FROM ____ ";
$sql_query[1] .= "WHERE ____ ";
$sql_query[1] .= "AND ____ ";
$sql_query[1] .= "GROUP BY ____ ";
$sql_query[1] .= "ORDER BY ____ ";
$sql_query[1] .= "ASC";

$sql_result[1] = mysql_query($sql_query[1],$db_connect);
$sql_num[1] = mysql_num_rows($sql_result[1]);

    if($sql_num[1] > 0) {
    
    $cur[1] = 1;
        
    		while ($sql_num[1] >= $cur[1]) {
    		
    		$row = mysql_fetch_array($sql_result[1]);
    		
    		$____ = $row["____"];  		
    		
    		echo"
    		" . $____ . "<br />
    		";
    		
    		$cur[1]++;
    		}
    
    }

So, my question is : is there a way to do the same thing with less code?

Thanks.

 

[sleipnir214]

Sure.

Since PHP's mysql_fetch_*() functions all return FALSE when there is no more data in a result set your code can drop the mysql_num_rows() call and while-loop on the mysql_fetch_array() call.

Also, quit assigning values from the result set to variables and just reference the result set array.

$sql_query[1] = "SELECT ____ ";
$sql_query[1] .= "FROM ____ ";
$sql_query[1] .= "WHERE ____ ";
$sql_query[1] .= "AND ____ ";
$sql_query[1] .= "GROUP BY ____ ";
$sql_query[1] .= "ORDER BY ____ ";
$sql_query[1] .= "ASC";

$sql_result[1] = mysql_query($sql_query[1],$db_connect);

while ($row = mysql_fetch_array($sql_result[1])
{
            echo"
            " . $row["____"] . "<br />
            ";
}

Want the best answers? Ask the best questions!

TANSTAAFL!!

 

[Sleidia]

Wow .. that's clean and beautiful

Thanks for that!

I see you're still a very active member on this site.
BTW, what's your projects for the coming year?