shopping cart syntax error

[pulpgirl]

getting a bizzare error on this page:

http://www.paceprints.com/secure/order-viewcart.asp

happens when there is nothing added to the cart. BUT if you add something to the cart and then remove it.. it shows you the cart as empty without a problem.

i get a syntax error which then refers to this line:

<%
Set Conn = Server.CreateObject("ADODB.Connection")
Set rsAddItem = Server.CreateObject("ADODB.Recordset")
Conn.ConnectionTimeout = 0
Conn.Open "dsn=paceprintscatalog;uid=paceprints;pwd=pace212prints;"
rsAddItem.Open "Select b.*, a.artistID AS artistID, a.firstname AS firstname, a.lastname AS lastname FROM paceprints.basket AS b, paceprints.stocklist AS s, paceprints.artists AS a WHERE b.printID = s.UID AND s.artistID=a.artistID AND b.basketID =" & Session("basketID"), Conn, 1, 3
%>


any ideas?

 

[gmmastros]

You're getting this error because Session("basketID") is blank.

Your resulting query looks like...

[tt][blue]WHERE b.printID = s.UID AND s.artistID=a.artistID AND b.basketID =[/blue][/tt]



-George

"the screen with the little boxes in the window." - Moron

 

[pulpgirl]

thank you
(obvioulsy very new at this..)

 

[pulpgirl]

alright.. sorry,

i'm not surehow t go about fixing this..
tries adding this:

<%
if "basketID" = isNull Then
response.write("0")
end if
%>

but i'm going about this wrong...
any help or links to somewhere i can read up on how to fix this..would be great..

thanks!

 

[gmmastros]

Fixing the problem is easy. Knowing what the right thing to do is not. It depends on your application.

What do you want to have happen when the basketId is blank? Do you want to NOT return any records?

You could bypass the query entirely.

If Session("BasketId") <> "" Then
  ' All your existing code here.
End If

You could also rely on an implicit data type conversion in your query. This method relies on the fact that an empty string will be converted to the value 0 when compared with an integer column. So you could change this...

AND b.basketID =" & Session("basketID")

To:

AND b.basketID =[!]'[/!]" & Session("basketID") [!]& "'" [/!]

By putting apostrophes around your data, the resulting query would look like...

[tt][blue]WHERE b.printID = s.UID AND s.artistID=a.artistID AND b.basketID = ''[/blue][/tt]

This will not return any records, but it also will not fail.

I hope this helps.

-George

"the screen with the little boxes in the window." - Moron

 

[pulpgirl]

loads of help! thank you!