Sessions not ending 1

[andy98]

Hi

I have just today started to look into PHP sessions and have created my LOGIN page. But when I LOGOUT and close the browser. I can still open a new browser window and bypass the LOGIN page and access other parts of my application.

When I login I set the following variable:

$_SESSION['Logged_In'] = "True";

In my logout I am doing this:

<?
session_start(); 
header("Cache-control: private"); //IE 6 Fix 
session_unregister('Logged_In');
$_SESSION['Logged_In'] = False;
$_SESSION['s_password'] = False;

$_SESSION = array(); 
session_destroy(); 

    // Redirect to show results.. 
echo "<script>document.location.href='index.php'</script>";

?>

And the top of the page I access afterwards - to see if it will kick me out - I have this - And this is where I think it must be wrong - but I cannot see it! It bypasses this code and runs the page! Any help greatly appreciated!

<?php 
session_start(); 
if ($_SESSION['Logged_In'] = FALSE) 

{
echo "<script>document.location.href='index.php'</script>";
}

http://www.goplanetgo.co.uk

 

[RISTMO]

Are you closing all your open browsers or just the one that you were viewing the site with? All the open browsers should be closed. And if you close all the open browsers, it won't destroy the session on the server, but it will end it from your machine.

Rick

http://www.ristmo.com/

 

[andy98]

Yes - i am closing all browser sessions. I'm convinced it must be in the page that I later try to access because I test for a session variable when I go back to the index.php page an it is blank - but when I try the URL to a specific page with this code at the top of the page:

<?php 
session_start(); 
if ($_SESSION['Logged_In'] = FALSE) 

{
echo "<script>document.location.href='index.php'</script>";
}

it doesn't go back to the index.php page like I am expecting it to do!

I can't see where I am going wrong!

http://www.goplanetgo.co.uk

 

[RISTMO]

Try this:

<?
session_start();
header("Cache-control: private"); //IE 6 Fix
$_SESSION['Logged_In'] = False;
$_SESSION['s_password'] = False;

$_SESSION = array();

    // Redirect to show results..
echo "<script>document.location.href='index.php'</script>";

See if that does what you want.

Rick

http://www.ristmo.com/

 

[andy98]

Tried that in my LOGOUT page but still the same!

http://www.goplanetgo.co.uk

 

[sleipnir214]

Your problem is in this line:

if ($_SESSION['Logged_In'] = FALSE)

you're using the assignment operator, not the comparison operator. The line should read:

if ($_SESSION['Logged_In'] [red]==[/red] FALSE)

In the case of using the assignment operator in an if-clause, the assignment returns whatever is assigned. In this case, FALSE, so the statement in the clause is never run.

Want the best answers? Ask the best questions!

TANSTAAFL!!

 

[andy98]

Many thanks! You don't know how many hours today I have spent trying to work out why this doesn't work!

God Bless

Andy

http://www.goplanetgo.co.uk

 

[RISTMO]

I've made that mistake so many times. It's usually the smallest errors that cause so much frustration, just because they're so hard to notice after you've been staring at the code for very long.

Rick

http://www.ristmo.com/

 

[andy98]

Hey thanks anyway Rick - it's helpful just to have someone confirm that there was nothing great that was wrong.

God Bless

Andy

http://www.goplanetgo.co.uk