Service Pack 3 Install Issue

[TechMerlin]

Hi All,

I have a few legacy machines still wiht XP SP2 on them and am trying to script a logoff script to read the reg value of HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\CSDVersion for the value of "Service Pack 2" and if so to run the SP3 installer silently. but for the life of me the I can not seem to get the script to run without exiting after checking the regvalue.

what am I missing here

REM @echo off
find | reg query "HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\CSDVersion"
if "Service Pack 2" goto Install
if other goto End

:Install
echo Installing Service Pack 3
\\<servername>\<Sharename>\WINXPSP3.msi /quiet /norestart

:end

 

[Sympology]

Try sticking a pause after each line. That way you can see whats happening

Robert Wilensky:
We've all heard that a million monkeys banging on a million typewriters will eventually reproduce the entire works of Shakespeare. Now, thanks to the Internet, we know this is not true.

 

[linney]

Is your Syntax correct for Reg Query? Does it need a /v or something?

REG Command in Windows XP
Querying keys

http://www.petri.co.il/reg_command_in_windows_xp.htm

Reg query

http://technet.microsoft.com/en-us/library/cc742028(WS.10).aspx

 

[Freestone]

Maybe you can base code off the following example?

@echo off
echo.

reg query "HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion" /v CSDVersion | find "Service Pack 2"

if errorlevel 2 goto Error
if errorlevel 1 goto NotFound

echo Search text found
goto End

:Notfound
echo Search text not found
goto End

:Error
echo Error occurred while executing Find command

:End
echo.