Search and replace string (smiley generation) 1

[chrismassey]

Hello,

I am trying to search for a particular string and replace it with an image. Basically if a user types in a smiley e.g. , its replaced with the gif image of the smiley. On test, nothing at all is printed from the text file storing the message data, not even non smiley strings. Below is the section of code I used which seems to be in a slight bit of a mess therefore there may be a more appropriate way to do this. Bare in mind that smileys may appear anywhere in the message therefore the code needs to be able to find one anywhere within and evaluate all occurences...

	my $angry = 'Smileys/angry.gif'; 		my $angryf = '\]\:\(';
	my $cry = 'Smileys/cry.gif'; 			my $cryf = '\:\'\(';
	my $confused = 'Smileys/confused.gif'; 		my $confusedf = '\:\s';
	my $evilgrin = 'Smileys/evilgrin.gif'; 		my $evilgrinf = '\]\:\)';
	my $happy = 'Smileys/happy.gif'; 		my $happyf = '\:\)';
	my $sad = 'Smileys/sad.gif'; 			my $sadf = '\:\(';
	my $smile = 'Smileys/smile.gif'; 		my $smilef = '\:\d';
	my $tongue = 'Smileys/tongue.gif';		my $tonguef = '\:\p';
	my $wink = 'Smileys/wink.gif'; 			my $winkf = '\;\)';
	
	my $img_src1 = '\<img src\=\"';
	my $img_src2 = '\"\>';

	$message[2] =~ s/$angryf/$img_src1$angryf$img_src2/ig;
	$message[2] =~ s/$cryf/$img_src1$cry$img_src2/ig;
	$message[2] =~ s/$confusedf/$img_src1$confusedf$img_src2/ig;
	$message[2] =~ s/$evilgrinf/$img_src1$evilgrinf$img_src2/ig;
	$message[2] =~ s/$happyf/$img_src1$happyf$img_src2/ig;
	$message[2] =~ s/$sadf/$img_src1$sadf$img_src2/ig;
	$message[2] =~ s/$smilef/$img_src1$smilef$img_src2/ig;
	$message[2] =~ s/$tonguef/$img_src1$tonguef$img_src2/ig;
	$message[2] =~ s/$winkf/$img_src1$winkf$img_src2/ig;

Thank you

 

[chrismassey]

Just one other thing...

I have backslashed unneccesarily because I thought that may have been a problem, so please ignore the \'s as I know that they will be taken literally.

Chris

 

[stevexff]

You are doing the same thing for each smiley, but with different data. So separate the thing you are doing from the data you are using to do it. This gets rid of all the dodgy variables and allows you to put it in a loop.

use strict;
use warnings;

my %smileys;

while (<DATA>) {
  chomp;
  my ($smiley, $file) = split /\s+/;
  $smileys{$smiley} = $file;
}

print smilify("he he :-)"), "\n";
print smilify("smiley overload :):)(8(|) :-)"), "\n";

sub smilify {
  my $string = shift;
  $string =~ s/\Q$_\E/<img src=\"Smileys\/$smileys{$_}\.gif\" \/>/g foreach (keys %smileys);
  return $string;
}

__DATA__
:-) smiley
:) smiley
]:( frown
(8(|) homer

Then you can just add more smileys as you discover them.

Steve

[small]"Every program can be reduced by one instruction, and every program has at least one bug. Therefore, any program can be reduced to one instruction which doesn't work." (Object:erlDesignPatterns)[/small]

 

[rharsh]

I'm all for the hash lookup idea as well. But looking at the examples there could be a small problem. In particular, angry could show up as sad ([blue]][/blue] vs. [blue][/blue]) and evilgrin could should up as happy ([blue]][/blue] vs [blue][/blue]) depending on which emoticon you search for first.

Probably the easiest way to fix the problem is to sort the keys in descending order based on length (assuming all the extra back-slashes have been removed.)

 

[brigmar]

Another tip.... check for whitespace surrounding the smiley.
One thing I've grown hate about certain IM clients is them 'smilifying' something I type which was not meant to be smilied.

 

[chrismassey]

Hey,

Nice one, thank you very much steve for providing that code, it did the job nicely :-D. I had issues with ordering of smileys, as rharsh said, some showed up incorrectly, however I ordered them as best as I could and changed a couple of the smiley codes. And brigmar, thank you for your tip, in the data i made sure there was a space either side.

Thank you very much,

Chris