Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Register Log in
  • Congratulations SkipVought on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

Script with three nested loops taking a long time to run, can it be improved ? 2

Status
Not open for further replies.
bobbybeech

bobbybeech

IS-IT--Management
Jan 16, 2020
4
0
0
GB
Hi
I am assembling a price list for pallet gates which is based on height, depth and width which have a minimum and maximum and vary in 50mm sizes. I've written a script with three loops, the first traverses the height min/max and dictates a starting price from a csv file, the second and third loops traverse the depth min/max and width min/max and set a price to add on for each increase in depth and width. The end of each iteration comes up with a final price for each HxDxW. The final prices need to closely match what is currently a manual system and therefore for some of the prices I add one amount and for others a different amount. This is set with if else statements. The script is doing what I want it to but it takes a long time to run and I'm having to adjust values to match the existing manual system. I run it using reduced min/max values but ideally need a full data set to prove the values. I would appreciate if anyone can see any improvements, I'm sure awk can run faster than shell but am not experienced enough to write optimal code. Thanks. The script and csv file are attached and shown below:
Script:
#!/bin/bash
#
startdate=`date`
outfile=price_list.txt
rm $outfile
# create full price list
full=1
if [ $full -gt 0 ]; then
minh=1750
maxh=2000
mind=1400
maxd=2000
minw=1400
maxw=3000
else
minh=1450
maxh=3000
mind=1100
maxd=3700
minw=1200
maxw=3000
fi
minstanh=1800
maxstanh=2600
minstand=1450
maxstand=1650
minstanw=1600
maxstanw=3000
gatesizediff=50
# create three loops and base prices on standard prices in ../Database/GatePrices-20200109.csv
h=$minh
while [ $h -le $maxh ]
do
d=$mind
# get minimum price related to height from standard 1800
if [ $h -lt $minstanh ]; then
hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$minstanh '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
let "hprice=$hprice-10"
elif [ $h -ge $minstanh -a $h -lt $(( minstanh +200 )) ]; then
#let "minstanh=$minstanh+200"
hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$((minstanh)) '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
#else
#hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$minstanh '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
elif [ $h -ge $((minstanh+200)) -a $h -lt $(( minstanh +400 )) ]; then
hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$((minstanh+200)) '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
elif [ $h -ge $((minstanh+400)) -a $h -lt $(( minstanh +600 )) ]; then
hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$((minstanh+400)) '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
elif [ $h -ge $((minstanh+600)) -a $h -lt $(( minstanh +800 )) ]; then
hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$((minstanh+600)) '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
elif [ $h -ge $((minstanh+800)) -a $h -lt $(( minstanh +1000 )) ]; then
hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$((minstanh+800)) '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
elif [ $h -ge $((minstanh+1000)) -a $h -lt $(( minstanh +1200 )) ]; then
hprice=860
else
hprice=870
fi
echo $h $maxh $hprice `date`

# now loop round the depth sizes
dcount=0
w=$minw
while [ $d -le $maxd ]
do
if [ $d -lt $minstand ]; then
dprice=-10
else
dprice=`echo $dcount | awk '{printf "%2f\n",$0*4.45}'|awk -F. '{print $1"."substr($2,1,2)}'`
let "dcount++"
fi
echo h $h hprice $hprice d $d dprice $dprice total hxd `echo $hprice $dprice | awk -v h=$hprice -v d=$dprice '{printf "%2f\n",h+d}' | awk -F. '{print $1"."substr($2,1,2)}'`
# now loop round the width sizes
wcount=0
w=$minw
wl1=1600
wl2=1800
wprice=0
echo awk loop start w $w maxw $maxw minstanw $minstanw `date`
#echo $minstanw | awk -v w=$minw -v maxw=$maxw -v minstanw=$minstanw '{ while (w<=maxw) {
echo $minstanw | awk -v w=$minw -v maxw=$maxw -v minstanw=$minstanw '{ for (i = w; i <= maxw; i=i+50)
if (i <= minstanw ) {wprice=-10}
else {(wprice=100)} print wprice}; END { print wprice }'
echo awk loop end `date`
echo while loop start `date`
while [ $w -le $maxw ]
do
if [ $w -lt $minstanw ]; then
wprice=-10
elif [ $w -ge $wl1 -a $w -le $wl2 ]; then
if [ $wprice == "-10" ]; then
wprice=0
else
wprice=`echo $wprice | awk -v wp=$wprice '{printf "%2f\n",wp+7}' | awk -F. '{print $1"."substr($2,1,2)}'`
let "wcount++"
fi
else
wprice=`echo $wprice | awk -v wp=$wprice '{printf "%2f\n",wp+3.25}' | awk -F. '{print $1"."substr($2,1,2)}'`
#wprice=`echo $wcount | awk '{printf "%2f\n",$0*4.18}'|awk -F. '{print $1"."substr($2,1,2)}'`
let "wcount++"
fi
echo h $h maxh $maxh hprice $hprice d $d dprice $dprice w $w wprice $wprice total hxdxw `echo $hprice $dprice | awk -v h=$hprice -v d=$dprice '{printf "%2f\n",h+d}' | awk -F. '{print $1"."substr($2,1,2)}'` `echo $hprice $dprice $wprice | awk -v h=$hprice -v d=$dprice -v w=$wprice '{printf "%2f\n",h+d+w}' | awk -F. '{print $1"."substr($2,1,2)}'` >> $outfile
let "w=$w+$gatesizediff"
done
let "d=$d+$gatesizediff"
echo while loop end `date`
done
let "h=$h+$gatesizediff"
done
echo Started $startdate Finished `date`

CSV file
GatePriceId,GateModel,GateType,GateDescription,GateHeight,GateDepth,GateWidth,MinHeadRoom,GatePrice, PackingCost,Comment,AddedBy,DateAddedUpdated
1,BFS1500,Standard,,1500,1450,1600,2100,490,30,,,
2,PGS1625,Standard,,1625,1450,1600,2100,645,35,,,
3,PGS1625,Standard,,1625,1450,1800,2100,657,35,,,
4,PGS1625,Standard,,1625,1450,2000,2100,683,35,,,
5,PGS1625,Standard,,1625,1450,2200,2100,695,35,,,
6,PGS1625,Standard,,1625,1450,2400,2100,707,35,,,
7,12,Standard,,1650,1450,1600,2100,640,30,,,
8,12,Standard,,1650,1450,1800,2100,666,30,,,
9,12,Standard,,1650,1450,2000,2100,678,30,,,
10,12,Standard,,1650,1450,2200,2100,690,35,,,
11,12,Standard,,1650,1450,2400,2100,702,35,,,
12,12,Standard,,1650,1450,2600,2100,714,35,,,
13,12,Standard,,1650,1450,2800,2100,726,35,,,
14,12,Standard,,1650,1450,3000,2100,738,35,,,
15,LCHP1800,Standard,,1800,1450,1600,2100,770,35,,,
16,LCHP1800,Standard,,1800,1450,1800,2100,798,35,,,
17,LCHP1800,Standard,,1800,1450,2000,2100,811,35,,,
18,LCHP1800,Standard,,1800,1450,2200,2100,823,35,,,
19,LCHP1800,Standard,,1800,1450,2400,2100,836,40,,,
20,LCHP1800,Standard,,1800,1450,2600,2100,849,40,,,
21,LCHP1800,Standard,,1800,1450,2800,2100,862,40,,,
22,LCHP1800,Standard,,1800,1450,3000,2100,875,40,,,
23,LCHP2000,Standard,,2000,1450,1600,2300,780,35,,,
24,LCHP2000,Standard,,2000,1450,1800,2300,808,35,,,
25,LCHP2000,Standard,,2000,1450,2000,2300,821,35,,,
26,LCHP2000,Standard,,2000,1450,2200,2300,834,35,,,
27,LCHP2000,Standard,,2000,1450,2400,2300,846,40,,,
28,LCHP2000,Standard,,2000,1450,2600,2300,859,40,,,
29,LCHP2000,Standard,,2000,1450,2800,2300,872,40,,,
30,LCHP2000,Standard,,2000,1450,3000,2300,885,40,,,
31,LCHP2200,Standard,,2200,1450,1600,2500,790,35,,,
32,LCHP2200,Standard,,2200,1450,1800,2500,819,35,,,
33,LCHP2200,Standard,,2200,1450,2000,2500,832,35,,,
34,LCHP2200,Standard,,2200,1450,2200,2500,846,35,,,
35,LCHP2200,Standard,,2200,1450,2400,2500,859,40,,,
36,LCHP2200,Standard,,2200,1450,2600,2500,872,40,,,
37,LCHP2200,Standard,,2200,1450,2800,2500,886,40,,,
38,LCHP2200,Standard,,2200,1450,3000,2500,899,40,,,
39,LCHP2400,Standard,,2400,1450,1600,2700,800,35,,,
40,LCHP2400,Standard,,2400,1450,1800,2700,829,35,,,
41,LCHP2400,Standard,,2400,1450,2000,2700,842,35,,,
42,LCHP2400,Standard,,2400,1450,2200,2700,856,35,,,
43,LCHP2400,Standard,,2400,1450,2400,2700,869,40,,,
44,LCHP2400,Standard,,2400,1450,2600,2700,882,40,,,
45,LCHP2400,Standard,,2400,1450,2800,2700,895,40,,,
46,LCHP2400,Standard,,2400,1450,3000,2700,909,40,,,
47,LCHP2600,Standard,,2600,1650,1600,2900,850,40,,,
48,LCHP2600,Standard,,2600,1650,1800,2900,880,40,,,
49,LCHP2600,Standard,,2600,1650,2000,2900,894,40,,,
50,LCHP2600,Standard,,2600,1650,2200,2900,907,40,,,
51,LCHP2600,Standard,,2600,1650,2400,2900,921,45,,,
52,LCHP2600,Standard,,2600,1650,2600,2900,935,45,,,
53,LCHP2600,Standard,,2600,1650,2800,2900,948,45,,,
54,LCHP2600,Standard,,2600,1650,3000,2900,962,45,,,
 
Sort by date Sort by votes
Formatting and indentation go a long way to readability.
Code: 
#!/bin/bash
#
startdate=`date`
outfile=price_list.txt
rm $outfile
# create full price list
full=1
if [ $full -gt 0 ]; then
    minh=1750
    maxh=2000
    mind=1400
    maxd=2000
    minw=1400
    maxw=3000
else
    minh=1450
    maxh=3000
    mind=1100
    maxd=3700
    minw=1200
    maxw=3000
fi
minstanh=1800
maxstanh=2600
minstand=1450
maxstand=1650
minstanw=1600
maxstanw=3000
gatesizediff=50

# create three loops and base prices on standard prices in ../Database/GatePrices-20200109.csv
h=$minh
while [ $h -le $maxh ]
do
    d=$mind
    # get minimum price related to height from standard 1800
    if [ $h -lt $minstanh ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$minstanh '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
        let "hprice=$hprice-10"
    elif [ $h -ge $minstanh -a $h -lt $(( minstanh +200 )) ]; then
        #let "minstanh=$minstanh+200"
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
        #else
        #hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$minstanh '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+200)) -a $h -lt $(( minstanh +400 )) ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh+200)) '$5==h {print $9}' |
            head -1 | 
            awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+400)) -a $h -lt $(( minstanh +600 )) ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh+400)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+600)) -a $h -lt $(( minstanh +800 )) ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh+600)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+800)) -a $h -lt $(( minstanh +1000 )) ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh+800)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+1000)) -a $h -lt $(( minstanh +1200 )) ]; then
        hprice=860
    else
        hprice=870
    fi
    echo $h $maxh $hprice `date`

    # now loop round the depth sizes
    dcount=0
    w=$minw
    while [ $d -le $maxd ]
    do
        if [ $d -lt $minstand ]; then
            dprice=-10
        else
            dprice=`echo $dcount | 
                awk '{printf "%2f\n",$0*4.45}' |
                awk -F. '{print $1"."substr($2,1,2)}'`
            let "dcount++"
        fi
        echo h $h hprice $hprice d $d dprice $dprice total hxd `echo $hprice $dprice | 
            awk -v h=$hprice -v d=$dprice '{printf "%2f\n",h+d}' | 
            awk -F. '{print $1"."substr($2,1,2)}'`
        # now loop round the width sizes
        wcount=0
        w=$minw
        wl1=1600
        wl2=1800
        wprice=0
        echo awk loop start w $w maxw $maxw minstanw $minstanw `date`
        #echo $minstanw | awk -v w=$minw -v maxw=$maxw -v minstanw=$minstanw '{ while (w<=maxw) {
        echo $minstanw | awk -v w=$minw -v maxw=$maxw -v minstanw=$minstanw '{
            for (i = w; i <= maxw; i=i+50)
                if (i <= minstanw ) {wprice=-10}
                else {(wprice=100)} print wprice
            };
            END { print wprice }'
        echo awk loop end `date`
        echo while loop start `date`
        while [ $w -le $maxw ]
        do
            if [ $w -lt $minstanw ]; then
            wprice=-10
            elif [ $w -ge $wl1 -a $w -le $wl2 ]; then
                if [ $wprice == "-10" ]; then
                    wprice=0
                else
                    wprice=`echo $wprice |
                        awk -v wp=$wprice '{printf "%2f\n",wp+7}' | 
                        awk -F. '{print $1"."substr($2,1,2)}'`
                    let "wcount++"
                fi
            else
                wprice=`echo $wprice | 
                    awk -v wp=$wprice '{printf "%2f\n",wp+3.25}' | 
                    awk -F. '{print $1"."substr($2,1,2)}'`
                #wprice=`echo $wcount | awk '{printf "%2f\n",$0*4.18}'|awk -F. '{print $1"."substr($2,1,2)}'`
                let "wcount++"
            fi
            echo h $h maxh $maxh hprice $hprice d $d dprice $dprice w $w wprice $wprice total hxdxw `echo $hprice $dprice | 
                awk -v h=$hprice -v d=$dprice '{printf "%2f\n",h+d}' | 
                awk -F. '{print $1"."substr($2,1,2)}'` `echo $hprice $dprice $wprice | 
                awk -v h=$hprice -v d=$dprice -v w=$wprice '{printf "%2f\n",h+d+w}' | 
                awk -F. '{print $1"."substr($2,1,2)}'` >> $outfile
            let "w=$w+$gatesizediff"
        done
        let "d=$d+$gatesizediff"
        echo while loop end `date`
    done
    let "h=$h+$gatesizediff"
done
echo Started $startdate Finished `date`#!/bin/bash
#

startdate=`date`
outfile=price_list.txt
rm $outfile
# create full price list
full=1
if [ $full -gt 0 ]; then
    minh=1750
    maxh=2000
    mind=1400
    maxd=2000
    minw=1400
    maxw=3000
else
    minh=1450
    maxh=3000
    mind=1100
    maxd=3700
    minw=1200
    maxw=3000
fi
minstanh=1800
maxstanh=2600
minstand=1450
maxstand=1650
minstanw=1600
maxstanw=3000
gatesizediff=50

# create three loops and base prices on standard prices in ../Database/GatePrices-20200109.csv
h=$minh
while [ $h -le $maxh ]
do
    d=$mind
    # get minimum price related to height from standard 1800
    if [ $h -lt $minstanh ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$minstanh '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
        let "hprice=$hprice-10"
    elif [ $h -ge $minstanh -a $h -lt $(( minstanh +200 )) ]; then
    #let "minstanh=$minstanh+200"
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
    #else
    #hprice=`cat Database/GatePrices-20200109.csv | awk -F "," -v h=$minstanh '$5==h {print $9}' | head -1 | awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+200)) -a $h -lt $(( minstanh +400 )) ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh+200)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+400)) -a $h -lt $(( minstanh +600 )) ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh+400)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+600)) -a $h -lt $(( minstanh +800 )) ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh+600)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+800)) -a $h -lt $(( minstanh +1000 )) ]; then
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh+800)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
    elif [ $h -ge $((minstanh+1000)) -a $h -lt $(( minstanh +1200 )) ]; then
        hprice=860
    else
        hprice=870
    fi
    echo $h $maxh $hprice `date`

    # now loop round the depth sizes
    dcount=0
    w=$minw
    while [ $d -le $maxd ]
    do
        if [ $d -lt $minstand ]; then
            dprice=-10
        else
            dprice=`echo $dcount | 
                awk '{printf "%2f\n",$0*4.45}'|
                awk -F. '{print $1"."substr($2,1,2)}'`
            let "dcount++"
        fi
        echo h $h hprice $hprice d $d dprice $dprice total hxd `echo $hprice $dprice | 
            awk -v h=$hprice -v d=$dprice '{printf "%2f\n",h+d}' | 
            awk -F. '{print $1"."substr($2,1,2)}'`
        # now loop round the width sizes
        wcount=0
        w=$minw
        wl1=1600
        wl2=1800
        wprice=0
        echo awk loop start w $w maxw $maxw minstanw $minstanw `date`
        #echo $minstanw | awk -v w=$minw -v maxw=$maxw -v minstanw=$minstanw '{ while (w<=maxw) {
        echo $minstanw | awk -v w=$minw -v maxw=$maxw -v minstanw=$minstanw '{
            for (i = w; i <= maxw; i=i+50)
                if (i <= minstanw ) {wprice=-10}
                else {(wprice=100)} print wprice
            };
            END { print wprice }'
        echo awk loop end `date`
        echo while loop start `date`
        while [ $w -le $maxw ]
        do
            if [ $w -lt $minstanw ]; then
                wprice=-10
            elif [ $w -ge $wl1 -a $w -le $wl2 ]; then
                if [ $wprice == "-10" ]; then
                    wprice=0
                else
                    wprice=`echo $wprice | awk -v wp=$wprice '{printf "%2f\n",wp+7}' | awk -F. '{print $1"."substr($2,1,2)}'`
                    let "wcount++"
                fi
            else
                wprice=`echo $wprice | awk -v wp=$wprice '{printf "%2f\n",wp+3.25}' | awk -F. '{print $1"."substr($2,1,2)}'`
                #wprice=`echo $wcount | awk '{printf "%2f\n",$0*4.18}'|awk -F. '{print $1"."substr($2,1,2)}'`
                let "wcount++"
            fi
            echo h $h maxh $maxh hprice $hprice d $d dprice $dprice w $w wprice $wprice total hxdxw `echo $hprice $dprice |
                awk -v h=$hprice -v d=$dprice '{printf "%2f\n",h+d}' | 
                awk -F. '{print $1"."substr($2,1,2)}'` `echo $hprice $dprice $wprice | 
                awk -v h=$hprice -v d=$dprice -v w=$wprice '{printf "%2f\n",h+d+w}' | 
                awk -F. '{print $1"."substr($2,1,2)}'` >> $outfile
            let "w=$w+$gatesizediff"
        done
        let "d=$d+$gatesizediff"
        echo while loop end `date`
    done
    let "h=$h+$gatesizediff"
done
echo Started $startdate Finished `date`

Awk is vastly more capable than the things you're using it for.
Code: 
        hprice=`cat Database/GatePrices-20200109.csv | 
            awk -F "," -v h=$((minstanh)) '$5==h {print $9}' | 
            head -1 | 
            awk -F "." '{print $1}'`
This could so easily be one process (awk) instead of 4
Code: 
awk -F',' -v h=$((minstanh)) 'program' Database/GatePrices-20200109.csv

TBH, perhaps the whole thing should be in AWK.


--
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
 
Upvote 0 Downvote
Thanks, I realise the capabilities of awk which I sadly lack. If there's any aspect that can be awk'd I'll be very grateful. The third while loop to calculate width takes seven seconds per iteration on my well spec'd computer so any improvement on that will cut down the overall run time. Awaiting anxiously for any further help.....
 
Upvote 0 Downvote
Go for the innermost loops first, because they're the ones which ultimately run most often.

So constructs like this:
[pre]echo $wprice | awk -v wp=$wprice '{printf "%2f\n",wp+7}' | awk -F. '{print $1"."substr($2,1,2)}'[/pre]

Might be replaceable with this:
[pre]awk -v wp=$wprice 'BEGIN {printf "%.2f\n",wp+7}'[/pre]

Eg.
Code: 
$ wprice=12.345
$ echo $wprice | awk -v wp=$wprice '{printf "%2f\n",wp+7}' | awk -F. '{print $1"."substr($2,1,2)}'
19.34
$ awk -v wp=$wprice 'BEGIN {printf "%.2f\n",wp+7}'
19.34
You save the initial echo, which was only there to give the first awk invocation something to read, by using the special pattern "BEGIN".
You save the second awk invocation, which was there only to trim the floating point result, by making the first awk only print 2 digits after the decimal point to begin with.


--
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
 
Upvote 0 Downvote
Hi

Do you realize there is a completely useless code too ? This only generates some output to display, does not contribute to the generated content :
bobbybeech said:
[pre]echo awk loop start w $w maxw $maxw minstanw $minstanw `date`
#echo $minstanw | awk -v w=$minw -v maxw=$maxw -v minstanw=$minstanw '{ while (w<=maxw) {
echo $minstanw | awk -v w=$minw -v maxw=$maxw -v minstanw=$minstanw '{ for (i = w; i <= maxw; i=i+50)
if (i <= minstanw ) {wprice=-10}
else {(wprice=100)} print wprice}; END { print wprice }'
echo awk loop end `date`[/pre]
Click to expand...
Personally I would leave it out.

Salem said:
So constructs like this:
[tt]echo $wprice | awk -v wp=$wprice '{printf "%2f\n",wp+7}' | awk -F. '{print $1"."substr($2,1,2)}'[/tt]

Might be replaceable with this:
[tt]awk -v wp=$wprice 'BEGIN {printf "%.2f\n",wp+7}'[/tt]
Click to expand...
Please note that those two are not identical. For wprice=123.456 the original will result 130.45, while your will round it up to 130.46.

I would try it with something like this :
Code: 
[gray]#!/usr/bin/gawk -f[/gray]

[b]BEGIN[/b] [teal]{[/teal]
    [navy]FS[/navy][teal]=[/teal][i][green]","[/green][/i]

    [navy]outfile[/navy][teal]=[/teal][i][green]"price_list.txt"[/green][/i]
    [b]print[/b] [i][green]""[/green][/i] [teal]>[/teal] outfile

    [gray]# create full price list[/gray]
    [b]if[/b] [teal]([/teal]full[teal]) {[/teal]
        minh [teal]=[/teal] [purple]1750[/purple]
        maxh [teal]=[/teal] [purple]2000[/purple]
        mind [teal]=[/teal] [purple]1400[/purple]
        maxd [teal]=[/teal] [purple]2000[/purple]
        minw [teal]=[/teal] [purple]1400[/purple]
        maxw [teal]=[/teal] [purple]3000[/purple]
    [teal]}[/teal] [b]else[/b] [teal]{[/teal]
        minh [teal]=[/teal] [purple]1450[/purple]
        maxh [teal]=[/teal] [purple]3000[/purple]
        mind [teal]=[/teal] [purple]1100[/purple]
        maxd [teal]=[/teal] [purple]3700[/purple]
        minw [teal]=[/teal] [purple]1200[/purple]
        maxw [teal]=[/teal] [purple]3000[/purple]
    [teal]}[/teal]

    minstanh [teal]=[/teal] [purple]1800[/purple]
    maxstanh [teal]=[/teal] [purple]2600[/purple]
    minstand [teal]=[/teal] [purple]1450[/purple]
    maxstand [teal]=[/teal] [purple]1650[/purple]
    minstanw [teal]=[/teal] [purple]1600[/purple]
    maxstanw [teal]=[/teal] [purple]3000[/purple]
    gatesizediff [teal]=[/teal] [purple]50[/purple]
[teal]}[/teal]

[teal]! ([/teal][navy]$5[/navy] [b]in[/b] data[teal]) {[/teal]
    data[teal][[/teal][navy]$5[/navy][teal]] = [/teal][navy]$9[/navy]
[teal]}[/teal]

[b]END[/b] [teal]{[/teal]
    [gray]# create three loops and base prices on standard prices in ../Database/GatePrices-20200109.csv[/gray]
    h [teal]=[/teal] minh
    [b]while[/b] [teal]([/teal]h [teal]<=[/teal] maxh[teal]) {[/teal]
        d [teal]=[/teal] mind

        [gray]# get minimum price related to height from standard 1800[/gray]
        [b]if[/b] [teal]([/teal]h [teal]<[/teal] minstanh[teal]) {[/teal]
            hprice [teal]=[/teal] data[teal][[/teal]minstanh[teal]][/teal]
            hprice -[teal]=[/teal] [purple]10[/purple]
        [teal]}[/teal] [b]else if[/b] [teal]([/teal]h [teal]>=[/teal] minstanh [teal]&&[/teal] h [teal]<[/teal] minstanh [teal]+[/teal] [purple]200[/purple][teal]) {[/teal]
            hprice [teal]=[/teal] data[teal][[/teal]minstanh[teal]][/teal]
        [teal]}[/teal] [b]else if[/b] [teal]([/teal]h [teal]>=[/teal] minstanh [teal]+[/teal] [purple]200[/purple] [teal]&&[/teal] h [teal]<[/teal] minstanh [teal]+[/teal] [purple]400[/purple][teal]) {[/teal]
            hprice [teal]=[/teal] data[teal][[/teal]minstanh [teal]+[/teal] [purple]200[/purple][teal]][/teal]
        [teal]}[/teal] [b]else if[/b] [teal]([/teal]h [teal]>=[/teal] minstanh [teal]+[/teal] [purple]400[/purple] [teal]&&[/teal] h [teal]<[/teal] minstanh [teal]+[/teal] [purple]600[/purple][teal]) {[/teal]
            hprice [teal]=[/teal] data[teal][[/teal]minstanh [teal]+[/teal] [purple]400[/purple][teal]][/teal]
        [teal]}[/teal] [b]else if[/b] [teal]([/teal]h [teal]>=[/teal] minstanh [teal]+[/teal] [purple]600[/purple] [teal]&&[/teal] h [teal]<[/teal] minstanh [teal]+[/teal] [purple]800[/purple][teal]) {[/teal]
            hprice [teal]=[/teal] data[teal][[/teal]minstanh [teal]+[/teal] [purple]600[/purple][teal]][/teal]
        [teal]}[/teal] [b]else if[/b] [teal]([/teal]h [teal]>=[/teal] minstanh [teal]+[/teal] [purple]800[/purple] [teal]&&[/teal] h [teal]<[/teal] minstanh [teal]+[/teal] [purple]1000[/purple][teal]) {[/teal]
            hprice [teal]=[/teal] data[teal][[/teal]minstanh [teal]+[/teal] [purple]800[/purple][teal]][/teal]
        [teal]}[/teal] [b]else if[/b] [teal]([/teal]h [teal]>=[/teal] minstanh [teal]+[/teal] [purple]1000[/purple] [teal]&&[/teal] h [teal]<[/teal] minstanh [teal]+[/teal] [purple]1200[/purple][teal]) {[/teal]
            hprice [teal]=[/teal] [purple]860[/purple]
        [teal]}[/teal] [b]else[/b] [teal]{[/teal]
            hprice [teal]=[/teal] [purple]870[/purple]
        [teal]}[/teal]
        [b]print[/b] h[teal],[/teal] maxh[teal],[/teal] hprice[teal],[/teal] [COLOR=orange]strftime[/color][teal]([/teal][i][green]"%c"[/green][/i][teal],[/teal] [COLOR=orange]systime()[/color][teal])[/teal]

        [gray]# now loop round the depth sizes[/gray]
        dcount [teal]=[/teal] [purple]0[/purple]
        w [teal]=[/teal] minw
        [b]while[/b] [teal]([/teal]d [teal]<=[/teal] maxd[teal]) {[/teal]
            [b]if[/b] [teal]([/teal]d [teal]<[/teal] minstand[teal]) {[/teal]
               dprice [teal]=[/teal] -[purple]10[/purple]
            [teal]}[/teal] [b]else[/b] [teal]{[/teal]
                dprice [teal]=[/teal] dcount [teal]*[/teal] [purple]4.45[/purple]
                dcount[teal]++[/teal]
            [teal]}[/teal]
            [b]print[/b] [i][green]"h"[/green][/i][teal],[/teal] h[teal],[/teal] [i][green]"hprice"[/green][/i][teal],[/teal] hprice[teal],[/teal] [i][green]"d"[/green][/i][teal],[/teal] d[teal],[/teal] [i][green]"dprice"[/green][/i][teal],[/teal] dprice[teal],[/teal] [i][green]"total hxd"[/green][/i][teal],[/teal] hprice [teal]+[/teal] dprice

            [gray]# now loop round the width sizes[/gray]
            wcount [teal]=[/teal] [purple]0[/purple]
            w [teal]=[/teal] minw
            wl1 [teal]=[/teal] [purple]1600[/purple]
            wl2 [teal]=[/teal] [purple]1800[/purple]
            wprice [teal]=[/teal] [purple]0[/purple]

            [b]print[/b] [i][green]"while loop start"[/green][/i][teal],[/teal] [COLOR=orange]strftime[/color][teal]([/teal][i][green]"%c"[/green][/i][teal],[/teal] [COLOR=orange]systime()[/color][teal])[/teal]

            [b]while[/b] [teal]([/teal]w [teal]<=[/teal] maxw[teal]) {[/teal]
                [b]if[/b] [teal]([/teal]w [teal]<[/teal] minstanw[teal]) {[/teal]
                    wprice [teal]=[/teal] -[purple]10[/purple]
                [teal]}[/teal] [b]else if[/b] [teal]([/teal]w [teal]>=[/teal] wl1 [teal]&&[/teal] w [teal]<=[/teal] wl2[teal]) {[/teal]
                    [b]if[/b] [teal]([/teal]wprice [teal]==[/teal] -[purple]10[/purple][teal]) {[/teal]
                        wprice [teal]=[/teal] [purple]0[/purple]
                    [teal]}[/teal] [b]else[/b] [teal]{[/teal]
                        wprice [teal]+=[/teal] [purple]7[/purple]
                        wcount[teal]++[/teal]
                    [teal]}[/teal]
                [teal]}[/teal] [b]else[/b] [teal]{[/teal]
                    wprice [teal]+=[/teal] [purple]3.25[/purple]
                    wcount[teal]++[/teal]
                [teal]}[/teal]
                [b]print[/b] [i][green]"h"[/green][/i][teal],[/teal] h[teal],[/teal] [i][green]"maxh"[/green][/i][teal],[/teal] maxh[teal],[/teal] [i][green]"hprice"[/green][/i][teal],[/teal] hprice[teal],[/teal] [i][green]"d"[/green][/i][teal],[/teal] d[teal],[/teal] [i][green]"dprice"[/green][/i][teal],[/teal] [COLOR=orange]round[/color][teal]([/teal]dprice[teal]),[/teal] [i][green]"w"[/green][/i][teal],[/teal] w[teal],[/teal] [i][green]"wprice"[/green][/i][teal],[/teal] [COLOR=orange]round[/color][teal]([/teal]wprice[teal]),[/teal] [i][green]"total hxdxw"[/green][/i][teal],[/teal] [COLOR=orange]round[/color][teal]([/teal]hprice [teal]+[/teal] dprice[teal]),[/teal] [COLOR=orange]round[/color][teal]([/teal]hprice [teal]+[/teal] dprice [teal]+[/teal] wprice[teal]) >>[/teal] outfile

                w [teal]+=[/teal] gatesizediff
            [teal]}[/teal]

            d [teal]+=[/teal] gatesizediff
            [b]print[/b] [i][green]"while loop end"[/green][/i][teal],[/teal] [COLOR=orange]strftime[/color][teal]([/teal][i][green]"%c"[/green][/i][teal],[/teal] [COLOR=orange]systime()[/color][teal])[/teal]
        [teal]}[/teal]

        h [teal]+=[/teal] gatesizediff
    [teal]}[/teal]

    [b]print[/b] [i][green]"Started"[/green][/i][teal],[/teal] startdate[teal],[/teal] [i][green]"Finished"[/green][/i][teal],[/teal] [COLOR=orange]strftime[/color][teal]([/teal][i][green]"%c"[/green][/i][teal],[/teal] [COLOR=orange]systime()[/color][teal])[/teal]
[teal]}[/teal]

[COLOR=orange]function round[/color][teal]([/teal]value[teal])[/teal]
[teal]{[/teal]
    [b]return[/b] [COLOR=orange]gensub[/color][teal]([/teal][fuchsia]/.$/[/fuchsia][teal],[/teal] [i][green]""[/green][/i][teal],[/teal] [purple]1[/purple][teal],[/teal] [b]sprintf[/b][teal]([/teal][i][green]"%.03f"[/green][/i][teal],[/teal] value[teal]))[/teal]
[teal]}[/teal]

Run it like this :
Code: 
./bobbybeech.awk -vfull=1 Database/GatePrices-20200109.csv

[gray]# or[/gray]
gawk -f bobbybeech.awk -vfull=1 Database/GatePrices-20200109.csv
Things to note :[ul]
[li]Left out the useless loop I mentioned above[/li]
[li]Used the same rounding for all prices ( there were some inconsistencies in the Bash script as -10 and 0 sometimes were written with fractional part, other times without )[/li]
[li]Prices get truncated to 2 fractional digits as in the Bash script[/li]
[li]The full option is not hardcoded in the script, can be specified from the command line instead[/li]
[/ul]

Feherke.
feherke.github.io
 
Upvote 0 Downvote
Hi - wow that is truly impressive stuff !!! Runs in 1 second, the manual process has a few quirks to it so I'm going to have to add a couple of if/else statements but will be okay.
Thank you very much for this. I am eternally grateful...have a great weekend
 
Upvote 0 Downvote
How about giving your helpers a "STAR" (Great Post) for their efforts?

==================================
advanced cognitive capabilities and other marketing buzzwords explained with sarcastic simplicity


 
Upvote 0 Downvote
Good idea - have done that. Thanks to all that responded. Never too old to learn something
 
Upvote 0 Downvote
Status
Not open for further replies.

Similar threads

EdLentz
  • Locked
  • Question
How can I escape $1 and &amp;&amp; in a SED command
Replies
1
Views
111
feherke
feherke
grazinggoat2
  • Locked
  • Question
ksh script to add multiple lines to csv cell formatting help
Replies
0
Views
71
grazinggoat2
grazinggoat2
rigstars2
  • Locked
  • Question
linux nested for loops HELP .. 1
Replies
7
Views
109
rigstars2
rigstars2
pax94
  • Locked
  • Question
Script automating dynamic queries in a remote host
Replies
0
Views
62
pax94
pax94
g33man
  • Locked
  • Article
BASH script - array problem 1
Replies
1
Views
67
feherke
feherke

Part and Inventory Search

Sponsor

Back
Top