remove element [0] from an array

[jez]

Hi everyone,

I am using the following to remove items from an array i am building up. Users add items to the array and may need to remove them too, it all works ok, except when we get to the last element.

function removeLine(id){
    if(id == ''){
        return;
    }
    this.lines.splice(id,1);
    }

this is part of an object, hence the "this.lines" to identify the array.

It appears to simply fail when you effectively call

    this.lines.splice(0,1);

I can see why this might be the right thing if there is only one element in the array, but it causes problems when there are several items in the array and it is the first that needs to be removed.

Any suggestions?

Thanks.

 

[jez]

update....

now i am trying this ;-

function removeLine(id){
    if(id == ''){
        return;
    }
    if(id == 0){
        this.lines.shift();
    }else{
        this.lines.splice(id,1);
        }
}

but it is still not removing the item.
My error panel is clean so i am a bit lost on what its doing.

 

[jez]

[SOLVED]

if(id == ''){
        return;
    }

removed that and it works.