releasing a form

[megmogg]

Hi all

searched the archives, but couldnt find an answer.

I remember seeing somewhere that when you issue a thisform.release, the code immediatley following it still gets executed. Is there something I need to put after a release to stop any further code executing.

An example is on the save of a button, if an error occurs updating a table, then I do the following.

If errorfound=.t.
   messagebox("Error")
   thisform.release
end if

(continue doing save routine)

Thanks

 

[MarciaAkins]

Is there something I need to put after a release to stop any further code executing.

Modify your code as follows:

IF errorfound=.t.
   messagebox("Error")
   thisform.release
ELSE
  (continue doing save routine)
ENDIF

Marcia G. Akins

http://www.TightlineComputers.com

 

[Mike Lewis]

Megmogg,

And, by the way, don't forget to remove the space in your "end if". This isn't Basic, y'know <g>.

Mike


__________________________________
Mike Lewis (Edinburgh, Scotland)

My sites:
Visual FoxPro (www.ml-consult.demon.co.uk)
Crystal Reports (www.ml-crystal.com)

 

[megmogg]

Thanks for the replies.

my routine is quite complicated, is there no other way?

I'm sure I saw somewhere you can do it.

could I issue a RETURN and the release ?

 

[Mike Lewis]

MegMogg,

could I issue a RETURN and the release ?

Well, you could. To adapt Marcia's code:

IF errorfound=.t.
   messagebox("Error")
   thisform.release
   return 
ENDIF
(continue doing save routine)

That would work, but I'm not sure what it would save you.

Mike

__________________________________
Mike Lewis (Edinburgh, Scotland)

My sites:
Visual FoxPro (www.ml-consult.demon.co.uk)
Crystal Reports (www.ml-crystal.com)

 

[Mike Lewis]

.... and, by the way. Why do want to close the form after you notified the user of the error? Wouldn't it make more sense from the user interface point of view if you left the form open so that the user could deal with the error?

Mike


__________________________________
Mike Lewis (Edinburgh, Scotland)

My sites:
Visual FoxPro (www.ml-consult.demon.co.uk)
Crystal Reports (www.ml-crystal.com)

 

[megmogg]

Thanks for the replies.

Mike: It was just a simple example to show what I wanted to achieve.

The reason I want to issue a RETURN is because the routine is quite long and I am trying to structure the code without lots of IF's and ENDIF's

By putting in the RETURN, it makes the code easier to read.

Thanks

 

[alvechurchdata]

The reason I want to issue a RETURN is because the routine is quite long

Perhaps you should consider splitting the method into smaller units. Using RETURN to bail out of the middle of a method is a very procedural way of doing things.

Geoff Franklin

http://www.alvechurchdata.co.uk

 

[megmogg]

yes, I agree.

However, the routine is already written and this easily solves the issue. But in the future......

 

[alvechurchdata]

the routine is already written

If it ain't broke ... <g>

Geoff Franklin

http://www.alvechurchdata.co.uk

 

[Mike Lewis]

Megmogg,

Although I agree with Geoff about not putting a RETURN in the middle of the method, in fact this is something I often do myself to simplify the code -- especially if I want to bail out as a result of some exceptional condition. Not good practice, but it can be convenient.

I take your point about your error message just being an example.

Mike

__________________________________
Mike Lewis (Edinburgh, Scotland)

My sites:
Visual FoxPro (www.ml-consult.demon.co.uk)
Crystal Reports (www.ml-crystal.com)

 

[megmogg]

Thanks all for the replies.

My main issue is that the code for a save routine is a method in a form. If I was to structure it correctly, then the IF statements and indentation would be massive. Using the RETURN lets me structure the IF statements in smaller chunks, therefore less indentation.

The correct way, I persume, would be to put the save routine into a PRG. But the IDE interface I find arkward to manage for big projects. I would have to open the form and open the PRG and when there are hundreds of PRG's, it would be a pain to manage. The IDE would be better by being able to group PRG's to forms or some other grouping mechanism.....or am I missing the point?

 

[Mike Lewis]

Megmogg,

The correct way, I persume, would be to put the save routine into a PRG.

No. That would introduce an unwanted dependency, and prevent the form from being self-contained.

I suggest you stick to the solution you have chosen.

Mike

__________________________________
Mike Lewis (Edinburgh, Scotland)

My sites:
Visual FoxPro (www.ml-consult.demon.co.uk)
Crystal Reports (www.ml-crystal.com)

 

[megmogg]

Thanks all for you help and suggestions.