Sure, in a simple scenario instr is probably a preferable solution (simpler, faster, lightweight, builtin).
However Regular Expressions are a very powerful tool that allow us to do a LOT more than simply finding the position of a character. Given Swi's very specific request for a regexp solution I suspect that simply looking for @ is not the ultimate goal, even if that goal is as simple as learning about regexps (as I rather suspect that they are familiar with Instr and would already be using it if it were appropriate)