regular expression issue...

[newbie1006]

I have a script that would check a xml file and find me strings that are between tags <Register> ...</Register>

script is :
while (my $line = <FILE>)
{
if ($line =~ m/<Register>/)
{
my $nextline =<FILE>;

if ($nextline =~ /^(.*)]*<\/Register/)
{

my $string = $1;


push(@register_list, $string);


}

else
{
print "You have a problem \n";

}
}
}

which is giving me the following

SG_u_EO_RX_FI_RD_WR_PT_OET[4:0]
GG_RR_AA_FFER_ASD_u_aSD_DAS_B[99999999]
GG_RR_AA_u_aSD_DAS_C[25:0]

what can i do so i get only this

SG_u_EO_RX_FI_RD_WR_PT_OET
GG_RR_AA_FFER_ASD_u_aSD_DAS_B
GG_RR_AA_u_aSD_DAS_C

 

[PinkeyNBrain]

Not knowing how your xml file is put together, your code as written looks problematic. However, to keep things moving along and answer the question as asked: A couple of options

Trim off the trailing []'s after you've found the string

my $string = $1;
$string =~ s/\[.+// ;
push(@register_list, $string);

This will look for a "[" and everything after it, then remove it.

Trim off the []'s as you're finding themp

if ($str =~ /^(.*)\[[^[]+\]<\/Register/) {
   push(@register_list, $1) ;
};

One item that is (arguably) not an option - indent your code.

 

[PinkeyNBrain]

Reviewing my second example, this may be better

if ($str =~ /^(.*)\[[^\]]*\]<\/Register/) {
   push(@register_list, $1) ;
};

Breaking this down:
\[ ' find a left square bracket
[^\]]* ' everything that is not a right square bracket
\] ' find a right square bracket