RegExp Url's 1

Fendal · Jan 30, 2006

Hi All,

I'm using regular expression to find url's and hyper link them with string replace, what I have works fine untill the url has both "

http://"

and "

http://www."

ie:

http://www.test.com,

is there any simple change I can make to what I have to fix that ?

Code:

<body onload=hyperl();>
<div id="content" style="height:100px;border:red groove 4px">
</div>
<script type="text/javascript">
var str="[URL unfurl="true"]http://test.com[/URL] [URL unfurl="true"]www.test.com[/URL] [COLOR=red][URL unfurl="true"]http://www.test.com[/URL][/color]";


function hyperl (){
//var reurl = /((http:\/\/|www\.)[^\s]*)/ig;//failed
var reurl = /(http:\/\/[^\s]*)/ig;
var reurl2 = /(www\.[^\s]*)/ig;
var bm = str.match(reurl);
var mb = str.match(reurl2);

 if (bm !=null){str = str.replace(reurl,"<a href='"+bm+"' target='_about'>"+bm+"</a>");}

   if (mb !=null){str = str.replace(reurl2,"<a href='[URL unfurl="true"]http://"+mb+"'[/URL] target='_about'>"+mb+"</a>");}
document.getElementById('content').innerHTML=str;
}
</script>

Thanks for reading.

kaht · Jan 30, 2006

Just add another OR clause to the beginning of the regex:

Code:

//var reurl = /((http:\/\/|www\.[!]|http:\/\/www\.[/!])[^\s]*)/ig;

-kaht

How much you wanna make a bet I can throw a football over them mountains?

kaht · Jan 30, 2006

You might even want to try something like this, but I'm not sure how the regexp will handle the nested parens. If this doesn't work I'd stick with the example I posted above, it should work:

Code:

//var reurl = /((http:\/\/[!](www\.)*[/!]|www\.)[^\s]*)/ig;

-kaht

How much you wanna make a bet I can throw a football over them mountains?

Fendal · Jan 30, 2006

Thanks, Kaht,

I think the "var bm = str.match(reurl);" was causing me some problems, but I'm using your code with RE "$1" function now and all is well, Thanks again.

Code:

<body onload=hyperl();>
<div id="content" style="height:100px;border:red groove 4px">
</div>
<script type="text/javascript">
var str="[URL unfurl="true"]www.test.com[/URL] [URL unfurl="true"]http://test.com[/URL] [URL unfurl="true"]http://www.test.com[/URL] [URL unfurl="true"]www.test.com";[/URL]

function hyperl (){
var reurl = /((http:\/\/(www\.)*|www\.)[^\s]*)/ig;
str = str.replace(reurl,"<a href='$1' target='_about'>$1</a>");

document.getElementById('content').innerHTML=str;
}
</script>

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

RegExp Url's 1

Fendal

Technical User

kaht

Programmer

kaht

Programmer

Fendal

Technical User

Similar threads

Part and Inventory Search

Sponsor