RegExp sometimes and works and sometimes not

[stormbind]

Works in FireFox. Doesn't work in MSIE. In MSIE, the src="something" remains unchanged. Can someone please suggest the cause?

Many thanks,

<script>
function ViewAsx(videoCode) {
  videoCode = 'AsxGenerator.aspx?fn=' + videoCode;
  var v = document.getElementById('video');
  v.innerHTML = v.innerHTML.replace(/src="(.+?)"/, 'src="' + videoCode + '"');
  alert(v.innerHTML);
}
</script>

<a href="javascript:ViewAsx('somewhere')">link</a>

<div id="video">
<embed src="something"></embed>
</div>

--Glen

Memoria mihi benigna erit qui eam perscribam

 

[BillyRayPreachersSon]

If you alert v.innerHTML before trying to set it, you'll see the cause - IE is stripping the quotes around the attribute value.

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

Dan's Page [blue]@[/blue] Code Couch:

http://www.codecouch.com/dan/

Code Couch Snippets & Info:

http://www.codecouch.com/

The Out Atheism Campaign

 

[BillyRayPreachersSon]

P.S. Why use a regular expression to do this? Why not simply modify the SRC attribute using DOM methods?

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

Dan's Page [blue]@[/blue] Code Couch:

http://www.codecouch.com/dan/

Code Couch Snippets & Info:

http://www.codecouch.com/

The Out Atheism Campaign

 

[stormbind]

Well, because I think that using DOM is very gentle to the browsers and does not encourage them to automatically play the injected videos.

Thank you for spotting Microsoft's missing quotes. Maybe this isn't the best fix but it will do

if (document.all) v.innerHTML = v.innerHTML.replace(/src=(.*?) /, 'src=' + videoCode + ' ');
else v.innerHTML = v.innerHTML.replace(/src="(.+?)"/, 'src="' + videoCode + '"');

--Glen

Memoria mihi benigna erit qui eam perscribam