receiving strings from keyboard and storing base address in array of pointers...

[borkut]

void main()
{
char *names[6];
int i;
for(i=0;i<6;i++)
{
scanf("%s",names);
}
getch();
}

i am writing this code and compiller is not giving any error.i am using dev c++.why error?

 

[xwb]

You haven't allocated any space for the names. Say you allow up to 99 characters. Change the code to

names[i] = malloc(100);
scanf("%s",names[i]);

 

[SamBones]

Also, your array is too small. Your loop goes from 0 to 6 which is a total of 7 iterations of the loop. Your array "[tt]names[][/tt]" is only 6 long.

 

[borkut]

the code that i have given is not giving any compile time error.but at execution time it is failing to execute.why?

 

[jlasman]

Your original code is for 0 to 5, stated as 0 < 6, so the array size of 6 is good.


Jim Asman

http://www.spectracolorservices.com

 

[SamBones]

Oops, my bad.

Read it too fast.

Failing to execute? Does it actually not execute, or does it just do nothing? That's two different things.

Do you get an error message?

 

[borkut]

output screen is coming and then when i am entering a string, a window is coming and its saying that myprogram.exe has stoped working.

 

[xwb]

Have you made the mod I suggested? What does your program look like now?

 

[borkut]

to XWB,

using ur code(modification) my program is executing well.but i want to know why my code is not doing well.

char *names[6] in this cose 'names' is an array of pointers to string.

so whwn i m using
scanf("%s",names); this means that i m passing a pointer variable to scanf function.and pointer
variable holds an address so thats correct that i m passing an address to scanf function
and when i m enetering a string from keyboard then it should store the base address of
that string into that names's address.

 

[xwb]

A char* is just a pointer to a location: there is no where for it to store the information. It does, as you say, store the data in the address of the given string. As you have not initialized the string, it has nowhere to store it. With the mod I posted, it allocates space for program to store the information before reading in the data. So now, it has somewhere to store the data so it does not crash.