"Press any key to continue" function ... Problem when <Enter> is pressed ...

[TSch]

Hi everyone,

I included the following function into my latest script:

function fkt_continue
{
echo "\033[1;36mPress any key to continue (or <Q> to quit) ...\033[m"
stty -echo
stty raw
key=$(dd bs=1 count=1 2> /dev/null) > /dev/null
stty echo
stty -raw
if [ $key = "Q" -o "q" ];
 then
  exit 1
fi
}

So far so good and everything works fine except when you press the <Enter> key it will act like Q has been pressed and quit the script ... :-(

Any ideas why that's so and what I can do about it ?

Best Regards,
Thomas

 

[feherke]

Hi

Irrelevant what you press, that will always evaluate to true :

[blue]master #[/blue] key='Q'; [ $key = "Q" -o "q" ]; echo $?
0

[blue]master #[/blue] key='q'; [ $key = "Q" -o "q" ]; echo $?
0

[blue]master #[/blue] key='TSch'; [ $key = "Q" -o "q" ]; echo $?
0

There you wrote value of variable $key equals string "Q" or string "q" is not empty. I can not imagine the 2[sup]nd[/sup] part of expression to ever be anything else but true.

Maybe you want this instead :

[teal][[/teal] [navy]$key[/navy] [teal]=[/teal] [i][green]"Q"[/green][/i] -o [highlight][navy]$key[/navy] [teal]=[/teal][/highlight] [i][green]"q"[/green][/i] [teal]][/teal]

Feherke.
feherke.ga

 

[TSch]

My goodness, must have been too much code for me lately so I missed the fact that I forgot the second $key ... ;-)

Thanks a lot !