Problems with Form 2

[dmears1]

I have a pretty basic form here:

http://www.bestlifetraining.com/bli-registration.php

I am using a js function to validate the fields. I have a php statement to check and see if the submit button has been pressed:

if ($submit) {
//process form

Here's the problem: when you click "Sign Me Up" ($submit), the js function does work, however, after you click "ok" the form is posted anyway without giving the user the chance to make corrections.

I know the problem is with the php statement "if ($submit)--process form" so I've tried changing the condition of the if statement but have had no success.

Here is the js:

<script language="JavaScript">
function IsFormComplete(FormName) {
	var x       = 0
	var FormOk  = true
	
	while ((x < document.forms[FormName].elements.length) && (FormOk)) {
		if (document.forms[FormName].elements[x].value == '') {
			alert('Please enter the '+document.forms[FormName].elements[x].name +' and try again.')
			document.forms[FormName].elements[x].focus()
			FormOk = false
		}
		x ++
	}
	return FormOk
}

and the php if statement:

<?php
if ($submit) {
	//process form
	$db = @mysql_connect ('123.123.123.123', 'username', 'password') or
    die("Couldn't connect to localhost database with username: username");
	$db_selected = @mysql_select_db ('table', $db) or
    die("Couldn't hook into database: table");
	$sql = "INSERT INTO table(event, email, fname, lname, address, city, state, zip, country, phone, referral, guest_email, guest_fname, guest_lname, guest_address, guest_city, guest_state, guest_zip, guest_country, guest_phone, cc_number, cc_expiration, ccv_number, cc_name, guest_cc_number, guest_cc_expiration, guest_ccv_number, guest_cc_name) VALUES ('$event', '$email', '$fname', '$lname', '$address', '$city', '$state', '$zip', '$country', '$phone', '$referral', '$guest_email', '$guest_fname', '$guest_lname', '$guest_address', '$guest_city', '$guest_state', '$guest_zip', '$guest_country', '$guest_phone', '$cc_number', '$cc_expiration', '$ccv_number', '$cc_name', '$guest_cc_number', '$guest_cc_expiration', '$guest_ccv_number', '$guest_cc_name')";
	$results = @mysql_query ($sql) or
    die('Statement failed: ' . $sql);
} else {
	//display form
?>

Thanks in advance for any help.

http://www.Morter.com

http://www.BestLifeTraining.com

http://www.AbsoluteStudio.com

 

[Foamcow]

That's because you are confusing client side with server side validation.

If you make a form with an action that will submit the form to a script when the submit button is pressed then that is what will happen.

You will need to remove the action and do the actual submission through javascript - once the form data is validated on the client side.

Foamcow Heavy Industries - Web design and ranting
Buy Languedoc wines in the UK

 

[kaht]

The problem is in your submit tag with the onsubmit handler. You need to return the value:

<form onsubmit="[!]return[/!] IsFormComplete(FormName)">

By the way, further javascript questions should be asked in the javascript forum.

-kaht

[small] <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <B> <P> <.</B>[/small]
[small](He's back)[/small]

 

[Foamcow]

ignore my post above.... I didn't read the question properly!
Sorry.

Foamcow Heavy Industries - Web design and ranting
Buy Languedoc wines in the UK

 

[dmears1]

Thanks for the help. You got me on the right track. On the submit button I had the following HTML:

<input name="submit" type="submit" value="Sign Me Up!" OnClick=IsFormComplete("signmeup")>

I changed it to this and it seems to have solved the problem:

<input name="submit" type="submit" value="Sign Me Up!" OnClick="return IsFormComplete('signmeup')">

Thanks again!

http://www.Morter.com

http://www.BestLifeTraining.com

http://www.AbsoluteStudio.com

 

[Vragabond]

It is better still to put that code in the form tag like kaht showed. That will be more full proof (if user presses enter key, form is usually submitted but the button was never actually clicked.

Even better is to do your validation on the server. I can turn off javascript with one click and bypass all your validation.

 

[dmears1]

Thanks Vragabond.
I will give it a shot in the form tag. I didn't think about the button not being clicked.
I will be adding server-sided validation (php) as well, but I wanted to add the client-side first to ensure I have the js working properly first. This way the form is validated regardless of whether or not js is enabled.

http://www.Morter.com

http://www.BestLifeTraining.com

http://www.AbsoluteStudio.com