Please Help - No Clue What's Wrong

mtorbin · Dec 29, 2003

Hey all,

I have the following script that is running as an SSI. In it's current state, it gives me the following error, but still processes through:

[Mon Dec 29 16:16:06 2003] [error] [client xxx.xx.x.xx] Use of uninitialized value in concatenation (.) or string at /xxx/xxxxx/xxxxx/cgi-bin/ccForm.cgi line 14.

If I remove the "-wT" it won't process at all. This is a simple script, so it should not be a problem, but for some reason, I can't figure it out. Two things you will notice with this script:

1) The IP addresses have been replaced with "X".
2) There is some unncessary information that has been commented out.

Any advice?

============================================================

#!/usr/bin/perl -wT

use strict;
use CGI ':standard';

my $userInfo = "$ENV{'HTTP_USER_AGENT'}";
my $macInfo = "Mozilla/5.0 (Macintosh\; U\; PPC Mac OS X Mach-O\; en-US\; rv:1.4) Gecko/20030624 Netscape/7.1";
my $userIP = "$ENV{REMOTE_ADDR}";

my $userName = param('username');

my $passWord = param('password');

my $url = "

http://"

. $userName . ":" . $passWord . "\@xxx.xx.x.xx/controlCenter/redirect.html";

#if ($userInfo eq $macInfo) {

#THE IF STATEMENT BELOW IS USED FOR IP ADDRESS AUTHENTICATION ONLY
#
if ($userIP eq 'xxx.xx.x.xx') {
#
print "Content-type: text/html\n\n";
print "<form name=\"login\">\n";
# print "<form action=\"cgi-bin/ccForm.cgi\" method=\"post\">\n";
print "<input type=\"hidden\" name=\"server\" value=\"xxx.xx.x.xx/controlCenter/redirect.html\">\n";
print "<strong>Log into<br>The Control Center</strong>\n";
print "<br>\n";
print "<br>\n";
print "<table width=\"100\" height=\"100\" border=\"2\" cellpadding=\"2\" cellspacing=\"0\" bordercolor=\"#000000\" bgcolor=\"#cccccc\">\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\">Username</td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\"><input name=\"username\" type=text id=\"username\" size=11 ></td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\">Password</td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\"><input name=\"password\" type=password id=\"password\" size=11></td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"1\" valign=\"top\" bgcolor=\"#000000\"><img src=\"images/spacer.gif\" width=\"1\" height=\"1\"></td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"19\" align=\"center\" valign=\"top\"><input type=button value=\"Login\" onClick=\"Login(this.form)\" name=\"button\"></td>\n";
print "</tr>\n";
print "</table>\n";
print "</form>";
}

else {
print "Content-type: text/html\n\n";
print " ";
}

PaulTEG · Dec 29, 2003

You're not creating an instance of the CGI object to be able to read the variables $userName and $passWord

Print these values before the concatenation.

It's only a warning and should disappear when you use
$object=new CGI;
fairly close to the start of your script

HTH
--Paul

mtorbin · Dec 29, 2003

Paul,

I don't know that I totally understand you. This is what I currently have, where do I put the code that you suggested?

#!/usr/bin/perl -wT

use strict;
use CGI ':standard';

my $userIP = "$ENV{REMOTE_ADDR}";

my $userName = param('username');

my $passWord = param('password');

my $url = "

http://"

. $userName . ":" . $passWord . "\@172.25.1.9/controlCenter/redirect.html";

#if ($userInfo eq $macInfo) {

#THE IF STATEMENT BELOW IS USED FOR IP ADDRESS AUTHENTICATION ONLY
#
if ($userIP eq '172.25.1.35') {
#
print "Content-type: text/html\n\n";
print "<form name=\"login\">\n";
print "<input type=\"hidden\" name=\"server\" value=\"172.25.1.9/controlCenter/redirect.html\">\n";
print "<strong>Log into<br>The Control Center</strong>\n";
print "<br>\n";
print "<br>\n";
print "<table width=\"100\" height=\"100\" border=\"2\" cellpadding=\"2\" cellspacing=\"0\" bordercolor=\"#000000\" bgcolor=\"#cccccc\">\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\">Username</td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\"><input name=\"username\" type=text id=\"username\" size=11 ></td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\">Password</td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\"><input name=\"password\" type=password id=\"password\" size=11></td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"1\" valign=\"top\" bgcolor=\"#000000\"><img src=\"images/spacer.gif\" width=\"1\" height=\"1\"></td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"19\" align=\"center\" valign=\"top\"><input type=button value=\"Login\" onClick=\"Login(this.form)\" name=\"button\"></td>\n";
print "</tr>\n";
print "</table>\n";
print "</form>";
}
else {
print "Content-type: text/html\n\n";
print " ";
}

- MT

PaulTEG · Dec 29, 2003

Before

Code:

my $userIP = &quot;$ENV{REMOTE_ADDR}&quot;;

HTH
--Paul

mtorbin · Dec 29, 2003

Additionally, would this error be enough to bog down a high-end server running Apache 2?

- MT

PaulTEG · Dec 29, 2003

It's only a warning, so you should have no reason to worry, worst case is you'll probably have two lines in the log files instead of one.

It is a salient warning in that no data is being logged with respect to $userName and $passWord

HTh
--Paul

mtorbin · Dec 29, 2003

I put that in the top of the script where you suggested but all of a sudden the script bombed:

#!/usr/bin/perl -wT

use strict;
use CGI ':standard';

my $userInfo = "$ENV{'HTTP_USER_AGENT'}";
my $macInfo = "Mozilla/5.0 (Macintosh\; U\; PPC Mac OS X Mach-O\; en-US\; rv:1.4) Gecko/20030624 Netscape/7.1";

$object=new CGI;

my $userIP = "$ENV{REMOTE_ADDR}";
my $userName = param('username');
my $passWord = param('password');

.
.
.

Did I miss something? We're coming to the conclusion that Apache 2.0 does not work as well as 1.3. Thanks for your help.

- MT

PaulTEG · Dec 29, 2003

When you say bombed what is the error message now?

--Paul

siberian · Dec 29, 2003

It should not have anything to do with apache 1.3 vs 2.0, they are pretty much identical for what you are doing.

Your problem is that you are not using 'my' on your $object.

Change $object=new CGI;

to

my $object=new CGI;

Your error log would have said something about this.

siberian · Dec 29, 2003

Or remove the -T option

but 'my' is better here.

mtorbin · Dec 30, 2003

LOL... Ok, I'm starting to think this is an Apache 2.0 issue since we're having hoards of trouble with it already. This is what I have and I'm getting the same results (thank you for being patient BTW):

#!/usr/bin/perl -wT

use strict;
use CGI ':standard';

my $userInfo = "$ENV{'HTTP_USER_AGENT'}";
my $macInfo = "Mozilla/5.0 (Macintosh\; U\; PPC Mac OS X Mach-O\; en-US\; rv:1.4) Gecko/20030624 Netscape/7.1";
my $object = new CGI;
my $userIP = "$ENV{REMOTE_ADDR}";
my $userName = param('username');
my $passWord = param('password');
my $url = "

http://"

. $userName . ":" . $passWord . "\@XXX.XX.X.XXX/controlCenter/redirect.html";

if ($userIP eq 'XXX.XX.X.XXX') {
print "Content-type: text/html\n\n";
print "<form name=\"login\">\n";
print "<input type=\"hidden\" name=\"server\" value=\"XXX.XX.X.XXX/controlCenter/redirect.html\">\n";
print "<strong>Log into<br>The Control Center</strong>\n";
print "<br>\n";
print "<br>\n";
print "<table width=\"100\" height=\"100\" border=\"2\" cellpadding=\"2\" cellspacing=\"0\" bordercolor=\"#000000\" $
print "<tr>\n";
print "<td height=\"20\" valign=\"top\">Username</td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\"><input name=\"username\" type=text id=\"username\" size=11 ></td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\">Password</td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"20\" valign=\"top\"><input name=\"password\" type=password id=\"password\" size=11></td>\n";
print "</tr>\n";
print "<tr>\n";
print "<td height=\"1\" valign=\"top\" bgcolor=\"#000000\"><img src=\"images/spacer.gif\" width=\"1\" height=\"1\"></$
print "</tr>\n";
print "<tr>\n";
print "<td height=\"19\" align=\"center\" valign=\"top\"><input type=button value=\"Login\" onClick=\"Login(this.form$
print "</tr>\n";
print "</table>\n";
print "</form>";
}

else {
print "Content-type: text/html\n\n";
print " ";
}

What am I missing?

- MT

PaulTEG · Dec 30, 2003

mtorbin,

wrap your code in [ code] [/ code] tags, there's some hookey looking stuff in here with out the code formatting

--Paul

duncdude · Dec 30, 2003

shouldn't you have single quotes around the environment variable

my $userIP = "$ENV{REMOTE_ADDR}";

my $userIP = "$ENV{'REMOTE_ADDR'}";

Duncan

siberian · Dec 30, 2003

FOUND IT

my $url = "

http://";

. $userName . ":" . $passWord . "\@XXX.XX.X.XXX/controlCent
er/redirect.html";

You have a semi-colon after '

http://'

(my $url = "

http://";

.)

That is causing you heartaches

Dont blame apache, its your fault.

mtorbin · Dec 30, 2003

Thank you.... LOL... it's always the little things...

- MT

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Please Help - No Clue What's Wrong

mtorbin

Technical User

PaulTEG

Technical User

mtorbin

Technical User

PaulTEG

Technical User

mtorbin

Technical User

PaulTEG

Technical User

mtorbin

Technical User

PaulTEG

Technical User

siberian

Programmer

siberian

Programmer

mtorbin

Technical User

PaulTEG

Technical User

duncdude

Programmer

siberian

Programmer

mtorbin

Technical User

Similar threads

Part and Inventory Search

Sponsor