Picturebox Collection - How to approach? (VB2005)

[Karja]

Hello there,

This is more the less a follow-up on my previous post "Names of form Controls - Conditional Calling".

I am making a card game. There are a lot of places on the table where a specipic card must be displayed or hided. The accomplish this I wrote the follwing:

Public Sub Card_Set(ByVal PlayerNumber As Integer, ByVal CardNumber As Integer, _
           ByVal CardImage As String, Optional ByVal show As Boolean = True)
        Dim cname As String = "PictureBox" & PlayerNumber & CardNumber

        For Each ctl As Control In Me.Controls
            If ctl.Name = cname Then
                Dim objImage As Image = Image.FromFile("D:\Sources\Cards\" & Card_Image(CardNumber))
              [u]ctl.Image = objImage[/u]: ctl.Visible = show
            End If
        Next
    End Sub

Now the systems comes up with the following error message:
'Image' is not a member of 'System.Windows.Forms.Control' (See the underlinded part). I must use another collection or something but I am not sure what to do. Can somebody give me a push in the right direction. Thanks in advance.

Greetings,

 

[earthandfire]

Try:

CType(ctl1, PictureBox).Image = objImage

also an End For before End If will prevent the loop from continuing after you have found the appropriate Picture Box.

Hope this helps.

 

[earthandfire]

Actually as you are using 2005, you could simplify things:

and replace:

For Each ctl As Control In Me.Controls
If ctl.Name = cname Then
Dim objImage As Image = Image.FromFile("D:\Sources\Cards\" & Card_Image(CardNumber))
ctl.Image = objImage: ctl.Visible = show
End If
Next

with

CType(Me.Controls(cname), PictureBox).Image = objImage
CType(Me.Controls(cname), PictureBox).Visible = show


Hope this helps.

 

[Karja]

First thanks for your reply. I've tried to implement the solution given for VB2005 and replaced the code with yours. I am stuck again :-(

The code looks now like this...

Dim objImage As Image = Image.FromFile("D:\Webcontent\deStrijd\deStrijd\Cards\" & Card_Image(CardNumber))
[i]CType(Me.Controls(cname), PictureBox).Image = objImage[/i]
CType(Me.Controls(cname), PictureBox).Visible = show

Now the system comes up with the error (for the italic line):
"Use the "new" keyword to create an instance of the object"

So I tried, the following:

Dim objImage As New Image

But now the system comes up with:
"new" cannot be used in a class that 'MustInherit"

I am not sure what to do now. Can anybody help me on this?

 

[earthandfire]

Have you tried:

CType(Me.Controls(cname), PictureBox).Load("D:\Webcontent\deStrijd\deStrijd\Cards\" & Card_Image(CardNumber))

Hope this helps.

 

[Karja]

Hello,
I just got it working with the following:

Public Sub Card_Set(ByVal PlayerNumber As Integer, ByVal NumberCard As Integer, _
           ByVal ImageNumber As Integer, Optional ByVal show As Boolean = True)
        Dim cname As String = "PictureBox" & PlayerNumber & NumberCard
        For Each ctl As Control In Me.Controls
            If ctl.Name = cname Then
                Dim objImage As Image = Image.FromFile("D:\Webcontent\deStrijd\deStrijd\Cards\" & Card_Image(ImageNumber))
                CType(ctl, PictureBox).Image = objImage
                ctl.Visible = True : ctl.Refresh() : Exit For
            End If
        Next
    End Sub

Thanks for you help anyway. Learning all the time

 

[earthandfire]

I'm glad you've got it working, but if you look at my previous post, you will see that you don't specifically need an Image variable - you can load the file straight into the PictureBox.


Hope this helps.

 

[Karja]

Yes, I looked into it a little further just to improve my understandig. Your solution is much prettier as you don't have to use the loop.

Public Sub Card_Set(ByVal PlayerNumber As Integer, ByVal NumberCard As Integer, _
           ByVal ImageNumber As Integer, Optional ByVal show As Boolean = True)
        With CType(Me.Controls("PictureBox" & PlayerNumber & NumberCard), PictureBox)
            .Load("D:\Webcontent\deStrijd\deStrijd\Cards\" & Card_Image(ImageNumber))
            .Visible = show
            .Refresh()
        End With
    End Sub

I am always trying to accomplish task with as less code as possible without forgetting the readability. Thanks for your input!