PHP 5 array and String Offsets

[eiffel76]

Greetings,

I have an array to output a dropdown menu from a database that fails with the error "Cannot use string offset as an array". I'm using PHP 5 and I'm not sure how to change the function to be compatible.

Here's the string:
function tep_get_source_list($name, $show_other = false, $selected = '', $parameters = '')

"$show_other = false" is the offender. The intent is to have a dropdown menu where people can select which search engine they came from, or choose "other" to enter the information into a text field.

Here's the code:

function tep_get_source_list($name, $show_other = false, $selected = '', $parameters = '') {

$sources_array = array(array('id' => '', 'text' => PULL_DOWN_DEFAULT));
$sources = tep_get_sources();

for ($i=0, $n=sizeof($sources); $i<$n; $i++) {
$sources_array[] = array('id' => $sources[$i]['sources_id'], 'text' => $sources[$i]['sources_name']);
}

if ($show_other == 'true') {
$sources_array[] = array('id' => '9999', 'text' => PULL_DOWN_OTHER);
}

return tep_draw_pull_down_menu($name, $sources_array, $selected, $parameters);
}

Help is much apreciated

 

[sleipnir214]

Show the line of your code that generates the error.



Want the best answers? Ask the best questions! TANSTAAFL!

 

[eiffel76]

It's: $show_other = false

When it's removed, no error appears.

 

[eiffel76]

I just found this in the php.net's "PHP5 Backward Incompatible Changes" (

http://www.php.net/manual/en/migration5.incompatible.php

)
"Illegal use of string offsets causes E_ERROR instead of E_WARNING.

An example illegal use is:

 $str = 'abc'; unset($str[0]);.

How can "$show_other = false" be used compatibly?

 

[sleipnir214]

So when this line reads:

[tt]function tep_get_source_list($name, $show_other = false, $selected = '', $parameters = '') {[/tt]

you get the error but when it reads:

[tt]function tep_get_source_list($name, $show_other, $selected = '', $parameters = '') {[/tt]

it does not?



Want the best answers? Ask the best questions! TANSTAAFL!

 

[eiffel76]

There's no error when it reads:

function tep_get_source_list($name, $selected = '', $parameters = '') {

"$show_other = false" has to be completely removed (removing "= false" alone doesn't help).

 

[sleipnir214]

And the error is in that line or another line somewhere else?



Want the best answers? Ask the best questions! TANSTAAFL!