passing parameter in selectcommand of dataadapter

[vaichi123]

da = New SqlDataAdapter("Select Busunit from Product where name = @prod", dbcon)
da.SelectCommand.Parameters.Add("@prod",sqlDbType.VarChar, 24).Value = "prod"
da.Fill(ds, "Product")

In the above code, I am passing the value of prod to the sql in da and then filling the dataset in the last line.
I want to know if this is the right way to be able to pass a value in to sql in the first line above.

 

[cjelec]

I use the Parameter.Add command in this way

.Parameters.Add("@prod","Prod")
First Name, then value

The '.Value = "prod"' in your code is used for the returning value (i think)

I use caps for Parameter names as well, I don't if it something i just picked up or if its the way you have to do it (@PROD)?

 

[steve1rm]

Hello,

I like to do it this this method, i think it is much more clear.

dim cmd as new sqlcommand()
dim da as new sqldataadapter()

dim pProd as new sqlParameter()
pProd.parametername = "@Prod"
pProd.sqldbtype = sqldbtype.varchar()
pProd.direction = ? either input, or output or both
pProd.value = prod
cmd.parameter.add(pProd)

da.selectCommand = cmd.
da.fill(ds)

Steve