pass a "control" name to a function?

[reinholdj]

I have several functions that are somewhat redundant, and I would like to get rid of multiple functions by passing the "control" that the function is operating on as a parameter.

For example, currently we have:

function x1(data)
{
window.document.myForm.text1.value = data;
}

function x2(data)
{
window.document.myForm.text2.value = data;
}


What I would like to do is this:

function x(data,control)
{
window.document.myForm.[control].value = data;
}

But when I try that I get an error saying that it is not an object.

How do I do this?

Thanks,
John

 

[tsdragon]

You can pass the value of this as a parameter to a function from an onClick or onChange event, and it will pass a reference to the form object. Then you can say this.value. Or, you can pass a number or character string to the function and use that within the function. Ex:

onClick="x(this)"
onClick="x(1)"
onClick="x('string')

Tracy Dryden
tracy@bydisn.com

Meddle not in the affairs of dragons,
For you are crunchy, and good with mustard.

 

[anorakgirl]

if you're just passing the name of the control, you need to do:

function x(data,controlname)
{
  window.document.myForm[controlname].value = data;
}

(note the missing fullstop cf your code)

or as above, if the function is called from an event attached to the control, if you can pass a reference to the actual control using the "this" keyword like this:

onClick="x(this, data)"

then your function just needs to be:

function x(control, data)
{
  control.value = data;
}

any help?