PAC file using java script 1

[supportahm1980]

Not sure if this is the right forum But I am trying to create a pac file (proxy automatic configuration script)

Basially I want subnets 192.168.1.0 and 192.168.40.0 and 192.168.60.0 to use the proxy. But I am not sure how to do a AND statement in javascript.

Does this look ok?

function FindProxyForURL(url, host) 

{ 

   if (isInNet(myIpAddress(),"192.168.1.0", "255.0.255.0")) && (isInNet(myIpAddress(),"192.168.40.0", "255.0.255.0")) && (isInNet(myIpAddress(),"192.168.160.0", "255.0.255.0")) {

    return "PROXY 127.0.0.1:80"; 

else return "DIRECT"; 

}

 

[dwarfthrower]

That's how you do an AND alright, but the statement you're actually getting the script to ask there is:

Is my IP address in the 192.168.1.0 subnet AND the 192.168.40.0 subnet AND the 192.168.60.0 subnet?

Which will only ever return true if the IP address is contained in all three subnets. A bit like if your location was Tokyo AND London AND New York all at the same time.

What you really want to be asking is:
Is my IP address in the 192.168.1.0 subnet OR the 192.168.40.0 subnet OR the 192.168.60.0 subnet?

Replace your && (AND) with || (OR) and you should get better results.

_{Never be afraid to share your dreams with the world.
There's nothing the world loves more than the taste of really sweet dreams.}
Enable Apps

 

[dwarfthrower]

Also the general structure for an if/else block is"

if(condition){
  code here;
}
else{
  alternate code here;
}

so you might want to move that 'else' outside of the brackets for the 'if'.

_{Never be afraid to share your dreams with the world.
There's nothing the world loves more than the taste of really sweet dreams.}
Enable Apps

 

[supportahm1980]

I have changed things around with your help. thank you so much.

function FindProxyForURL(url, host)
 
if (isInNet(myIpAddress(),"192.168.1.0", "255.0.255.0")) || (isInNet(myIpAddress(),"192.168.40.0", "255.0.255.0")) || (isInNet(myIpAddress(),"192.168.160.0", "255.0.255.0"))
{
return "PROXY 127.0.0.1:80";
}
else {
  return "DIRECT"; 
}

 

[dwarfthrower]

Looks much more useful. Glad I could help.

_{Never be afraid to share your dreams with the world.
There's nothing the world loves more than the taste of really sweet dreams.}
Enable Apps