Optimize this function 3

[Bertramp]

Is there anyway to optimize this function:

CREATE function strip(@para varchar(110))
returns varchar(110)
as
begin
declare @i varchar(110)
if charindex('/',@para) > 0
set @i = left(@para,charindex('/',@para)-1)
else
Set @i = @para
return @i
end

The objective is to strip any characters after and including the '/' - e.g 'test/query' should return 'test' and any string not having the '/' character should be left as is

 

[gmmastros]

Your function can be re-written as...

CREATE function strip(@para varchar(110))
returns varchar(110)
as
  begin

    Return(Select Case When CharIndex('/', @para) > 0 
                       Then Left(@Para, CharIndex('/', @para) - 1)
                       Else @Para
                       End)
  End

For even better speed improvements, put this case syntax directly in to the query without using a function.

-George

Strong and bitter words indicate a weak cause. - Fortune cookie wisdom

 

[monksnake]

This is what I get

CREATE function strip(@para varchar(110))
returns varchar(110)
as
   begin
      return substring(@para, 1, case charindex('/',@para)
      when 0 then len(@para) else (charindex('/',@para))
      end)   
   end

<.