Operator= Causing Unhandled Exceptions

[Kalisto]

I have inherited a project that doesnt work, from someone who has since been persuaded to leave the company.

There are currently a number of things I cannot get working on this project, the biggest culprit is below

I have an Operator= Defined like

CPatient& CPatient::operator=(CPatient& p)
{
m_PostCode = p.GetPostCode();
m_Country=p.GetCountry();
m_Comment=p.GetComment(); 
m_State=p.GetState();
m_City=p.GetCity();
m_Adress=p.GetAdress();
m_DOB=p.GetDOB();
m_Doctor=p.GetDoctor();
m_ID=p.GetID();
m_FirstName=p.GetFirstName();
m_LastName =p.GetLastName();
m_Sex=p.GetSex();
return *this;
}

and a Global Patient Object, that I am updating via the equals.

Before the =, the CurrentPatient, and the temporary patient hold correct data.
During the assignment, I get an Unhandled Exception during the GetComment() function.

Can anyone suggest ways of tracking this error down, or common faults I can check to eliminate this issue?

Thanks
K

 

[Kalisto]

OK, fixed this.

 

[obislavu]

That is Okay but your code should look like here:

CPatient& CPatient::operator=(CPatient& p)
{
	if ( this != &p ) 
	{      // Copy 
		m_PostCode = p.GetPostCode();
		m_Country=p.GetCountry();
		m_Comment=p.GetComment(); 
		m_State=p.GetState();
		m_City=p.GetCity();
		m_Adress=p.GetAdress();
		m_DOB=p.GetDOB();
		m_Doctor=p.GetDoctor();
		m_ID=p.GetID();
		m_FirstName=p.GetFirstName();
		m_LastName =p.GetLastName();
		m_Sex=p.GetSex();
	}
	return *this;
}

-obislavu-

 

[Kalisto]

Thanks, good point, else Im copying needlessley sometimes.