NMS Formmail from sourceforge.net 1

[kelly5518]

Hi,

I've been using the formmail script from sourceforge.net that is a rewrite of Matt's FormMail.pl, and has better security as well as new features. This script has worked great for me except now I'm trying to add additional recipients and can't seem to get it to work. It only mails the results to the last recipient. Note: I'm using the recipient alias, but even when I tried it without the alias it only mailed the results to the last person listed.

In the form I'm using:

CODE
<input type="hidden" name="recipient" value="1,2">

... and in the script I'm using:


CODE
%recipient_alias = ('1' => 'firstemail@mydomain.com',
'2' => 'secondemail@mydomain.com');

Thanks for any suggestions.

 

[fishiface]

That fails because perl looks up [tt]$recipient_alias('1,2')[/tt] which doesn't exist.


If you're hard-coding the choice of recipient in the form, why not just

<input type="hidden" name="recipient" value="1">

and

[b]my[/b] %recipient_alias = (
  '1' => 'firstemail@mydomain.com,secondemail@mydomain.com',
  '2' => ...

Yours,

fish


[&quot;]As soon as we started programming, we found to our surprise that it wasn't as easy to get programs right as we had thought. Debugging had to be discovered. I can remember the exact instant when I realized that a large part of my life from then on was going to be spent in finding mistakes in my own programs.[&quot;]
--Maur

 

[kelly5518]

Thanks fish, I'll give that a try.

One other question though, why did you put the words my in front of %recipient_alias ?

That isn't how the script that I'm using is written.

Thanks a bunch,

kelly

 

[fishiface]

Early versions of perl used global variables and this made any onn-trivial code hard to develop: if you accidently re-used a variable name the resulting mess could be very hard to sort out.

Later perls offered lexical variables, introduced by the [tt]my()[/tt] operator. These are accessible only within the enclosing textual block (there are a couple of exceptions but they are universally helpful and natural) and they "stack", so that you can safely use, eg, [tt]my $i[/tt]within a subroutine without having to worry about the calling code having used $i for something else.

With very few exceptions, lexicals are safer than globals and getting into the habit of using them will save you many hours of debugging time. The [tt]use strict[/tt] pragma will help you devlop the habit: it complains if you use any globals without making your intention clear.

Yours,

fish

[&quot;]As soon as we started programming, we found to our surprise that it wasn't as easy to get programs right as we had thought. Debugging had to be discovered. I can remember the exact instant when I realized that a large part of my life from then on was going to be spent in finding mistakes in my own programs.[&quot;]
--Maur

 

[kelly5518]

Ok, thanks for the explanation.

I still haven't had a chance to try out your suggestion of how to use the alias, but it makes sense to do it the way you suggested and I'll give it a try as soon as I get a chance.

Thanks again,

 

[fishiface]

my pleasure,

f

[&quot;]As soon as we started programming, we found to our surprise that it wasn't as easy to get programs right as we had thought. Debugging had to be discovered. I can remember the exact instant when I realized that a large part of my life from then on was going to be spent in finding mistakes in my own programs.[&quot;]
--Maur

 

[kelly5518]

I've tried out the new alias and it works great! Thanks a bunch!

kelly