nextSibling Issue 1

[bean1234]

Hello All,

I am calling a javascrip function showHideAll as in the below code, the problem is that this.nextSibling always returns undefined.Please look at the following markup, by this.nextSibling I want to refer to teh next anchor tag <a>.

<a href="#" onclick="showHideAll(this.parentNode.parentNode,[b]this.nextSibling[/b]);return false;"><img src="./../resources/images/button_expcoll.gif; align="middle" width="9" height="10"></a>&nbsp;<a href="#" onclick="showHideAll(this.parentNode.parentNode,this);return false;">Expand All</a>
 </a>

 

[cLFlaVA]

your next sibling is the &nbsp;.

what you'll need to do is either 1) remove the &nbsp; from the code and instead use css to provide the spacing gap or 2) use a loop to find the next anchor sibling, rather than just the next sibling. i'd opt for #1.



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]

 

[bean1234]

Thanks cory!! I too opted #1.

 

[Tarwn]

Personally I would have chosen option 2. If you ever go back and edit your code, maybe space it out to read it easier, your going to break your javascript then spend an additional three days trying to figure out what you did originally and why it is broken.
Maintainable code after the fact is often less expensive then the extra 15-20 minutes of coding up front to make something maintainable.

-T

 

[cLFlaVA]

allow myself to rephrase my... self...

i would also opt for #2. i was being lazy.



*cLFlaVA
----------------------------
[tt]"quote goes here"[/tt]
[URL unfurl="true"]http://www.coryarthus.com/[/url]