Newbie needs proofreading help! can't get script to run!

fowlerlfc · May 23, 2002

Hello,

I know this will probably be a dumb mistake on my part, but I can't get the following script to run. Could someone please proofread it for me and help me out? Also, since I'm learning if you'd be so kind as to critique my work, that would also be helpful.

Here's the script:

<html>
<head>
<title>Workorder submission form</title>
</head>
<body>
<?
//haven't submitted form, so display it
if (!$submit)
{
?>
<table cellspacing="5" cellpadding="5">
<form action="<?echo $PHP_SELF; ?>" method="post">
<tr>
<td>Name:</td>
<td><input size="50" maxlength="250" type="text" name="name"></td>
</tr>
<tr>
<td>Extension:</td>
<td><input size="4" maxlength="4" type="text" name="ext"></td>
</tr>
<tr>
<td>Email:</td>
<td><input size="50" maxlength="250" type="text" name="email"></td>
</tr>
<tr>
<td>Issue/Error/Problem:</td>
</tr>
<tr>
<td><textarea name="issue" cols="40" rows="20"></textarea></td>
</tr>
<tr>
<td><input type="submit" name="submit" value="Add"></td>
</tr>
</form>
</table>
<?
}
else
{
//includes files
include("../conf.php&quot

;
include("../functions.php&quot

;

//setup up an error list array
$errorlist = array();
$count = 0;

//validate name field
if ($name) { $errorlist[$count] = "Invalid entry: Name"; count++; }

//validate ext field
if ($ext) { $errorlist[$count] = "Invalid entry: Extension"; count++; }

//validate email field
if ($email) { $errorlist[$count] = "Invalid entry: Email"; count++; }

//validate issue field
if ($issue) { $errorlist[$count] = "Invalid entry: Issue/Error/Problem"; count++; }

//check for errors in errorlist.
if (sizeof($errorlist)==0)
{
//if no errors found
//open db connection
$connection = mysql_connect($host, $user, $pass) or die("Unable to Connect!&quot

;
//select db
mysql_select_db($db) or die("Unable to select database!&quot

;
//generate and run query
$query = "INSERT INTO wo(name, ext, email, issue, timestamp) VALUES ('$name', '$ext', '$email', '$issue', now())";

$result = mysql_query($query) or die("Error in query: $query. " . mysql_error());
//echo result
echo "<font size=-1>Update Successful.<a href=list.php>Go back to the main menu</a>.</font>";
//close db
mysql_close($connection);
}
else
{
//if there are errors, print a list
echo "<font size=-1>The following errors were encountered:<br>";
echo "<ul>";
for ($x=0; $x<sizeof($errorlist); $x++)
{
echo "<li>$errorlist[$x]";
}
echo "</ul></font>";
}
}

?>
</body>
</html>

Thanks in advance for all of your help!

sleipnir214 · May 23, 2002

Okay, it's not running. Three things are considered helpful in this context.

1. What, in general terms, is your code supposed to do?
2. What deviation from expected behavior are your experiencing?
3. What, if any, error messages are being generated?

fowlerlfc · May 23, 2002

Sorry!

1. The script is supposed to display a form if the submit button hasn't been pushed. When submitted, the script connects to a mysql database (the db and tables exist), and inserts data.

2. When run, the script displays a white screen. No Html, no errors, no nothing.

3. See answer 2.

AnakinPt · May 23, 2002

Ok, now i will say one thing, what version have you got of PHP?

I'm saying this cause yesterday i installed 4.2.0 in my home computer and there was no error reporting.

some things i'm seeing in yor code:
replace all the vars from the form ex: $submit by $_POST['submit']

in the if, as you can have to show all errors, you should replace if($submit) by if(isset($_POST) && isset($_POST['submit']))

but when you put diplay_errors to on, you will se the errors you are getting. Anikin
Hugo Alexandre Dias
Web-Programmer
anikin_jedi@hotmail.com

fowlerlfc · May 23, 2002

I've got PHP 4.20.

I just turned display_errors = on.

I now get the following error:
Parse error: parse error in D:\Inetpub\

http://wwwroot\user\add.php

on line 46

I've checked this line of code here's an excerpt:

$errorlist = array();
$count = 0;

but don't see an error. Any ideas?

AnakinPt · May 23, 2002

is that the line that have the error ... or i'm getting blind. I don't see any errors in you code

Anikin
Hugo Alexandre Dias
Web-Programmer
anikin_jedi@hotmail.com

fowlerlfc · May 23, 2002

Okay, I've found part of the problem in the if statements that validate my fields i forgot to put $ in front of my variable names.

Now my form prints and displays the following message:

Warning: Undefined variable: submit in D:\Inetpub\

http://wwwroot\user\add.php

on line 9

the variable $submit is for my submit button which is defined on the form? Have I done something wrong?

fowlerlfc · May 23, 2002

Here's my script again. It's still showing an error of:

Warning: Undefined variable: submit in D:\Inetpub\

http://wwwroot\user\add.php

on line 9

Here's the script:

<html>
<head>
<title>Workorder submission form</title>
</head>
<body>
<?
//haven't submitted form, so display it
if (!$submit)
{
?>
<table cellspacing="5" cellpadding="5">
<form action="<?echo $PHP_SELF; ?>" method="post">
<tr>
<td>Name:</td>
<td><input size="50" maxlength="250" type="text" name="name"></td>
</tr>
<tr>
<td>Extension:</td>
<td><input size="4" maxlength="4" type="text" name="ext"></td>
</tr>
<tr>
<td>Email:</td>
<td><input size="50" maxlength="250" type="text" name="email"></td>
</tr>
<tr>
<td>Issue/Error/Problem:</td>
</tr>
<tr>
<td><textarea name="issue" cols="40" rows="20"></textarea></td>
</tr>
<tr>
<td><input type="Submit" name="submit" value="Add"></td>
</tr>
</form>
</table>
<?
}
else
{
//includes files
include("../conf.php&quot

;
include("../functions.php&quot

;

//setup up an error list array
$errorList = array();
$count = 0;

//validate name field
if ($name)
{
$errorList[$count] = "Invalid entry: Name"; $count++;
}

//validate ext field
if ($ext) { $errorList[$count] = "Invalid entry: Extension"; $count++; }

//validate email field
if ($email) { $errorList[$count] = "Invalid entry: Email"; $count++; }

//validate issue field
if ($issue) { $errorList[$count] = "Invalid entry: Issue/Error/Problem"; $count++; }

//check for errors in errorlist.
if (sizeof($errorList)==0)
{
//if no errors found
//open db connection
$connection = mysql_connect($host, $user, $pass) or die("Unable to Connect!&quot

;
//select db
mysql_select_db($db) or die("Unable to select database!&quot

;
//generate and run query
$query = "INSERT INTO wo(name, ext, email, issue, timestamp) VALUES ('$name', '$ext', '$email', '$issue', now())";

$result = mysql_query($query) or die("Error in query: $query. " . mysql_error());
//echo result
echo "<font size=-1>Update Successful.<a href=list.php>Go back to the main menu</a>.</font>";
//close db
mysql_close($connection);
}
else
{
//if there are errors, print a list
echo "<font size=-1>The following errors were encountered:<br>";
echo "<ul>";
for ($x=0; $x<sizeof($errorList); $x++)
{
echo "<li>$errorList[$x]";
}
echo "</ul></font>";
}
}

?>
</body>
</html>

danielhozac · May 23, 2002

As of PHP 4.2.0 (I think), register_globals is off by default. Just do as Anikin suggested above, or set register_globals to on in your php.ini file. //Daniel

fowlerlfc · May 23, 2002

I already have register_globals = on, and I just made the changes that anikin suggested. This resulted in the same error.

Any more ideas?

sleipnir214 · May 23, 2002

The problem is likely from the line which reads,

if (!$submit)

The error could be caused by one of two things:

1. you are running the script for the first tiime so the variable is not instantiated before you check on it. Try changing the line to:

if (! is_set($submit))

2. You need to be using the $_POST hash. Change the line to read:

if (!$_POST['submit'])

or probably more correctly:

if (! array_key_set ("submit", $_POST))

AnakinPt · May 24, 2002

Look my first post. I said that you should replace the if(!$submit)

Anikin
Hugo Alexandre Dias
Web-Programmer
anikin_jedi@hotmail.com

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

Newbie needs proofreading help! can't get script to run!

fowlerlfc

MIS

sleipnir214

Programmer

fowlerlfc

MIS

AnakinPt

Programmer

fowlerlfc

MIS

AnakinPt

Programmer

fowlerlfc

MIS

fowlerlfc

MIS

danielhozac

Programmer

fowlerlfc

MIS

sleipnir214

Programmer

AnakinPt

Programmer

Similar threads

Part and Inventory Search

Sponsor