NEED SOME HELP?! JAVA SCRIPT NOT WORKING

[CF7]

i am expericing some problems with this embedded JS in Coldfusion. i keep getting a syntax error and dont understand why
--------------------------------------------------------------
<a href="javascript:void(0)"
onclick='clicked()'> #dirList.name# </a><br />

<script language="javascript">
function clicked()
{

window.parent.document.getElementById("fileD").value="#replace(dirList.directory,'\','\\','ALL')#\\#dirList.name#";
<!--- document.getElementById("fileLink").style.color="50141E"; --->
window.parent.document.getElementById("bC").disabled="true";
document.write("A file has been set. to remove it please click <a href='javascript:void(0)' onclick='window.parent.document.getElementById('fileD').value='null'; window.parent.document.getElementById('bC').disabled='false'; window.location.href='#cgi.SCRIPT_NAME#';'> here </a> , otherwise click <strong>submit</strong> to continue.");

}

 

[feherke]

Hi

The disabled property is boolean, not string.

window.parent.document.getElementById("bC").disabled=true

But probably the problem is not that.

i keep getting a syntax error

What syntax error ?

And please arrange your code abit to be easier to read. And enclose it between [tt][ignore]

[/ignore][/tt] and [tt][ignore]

[/ignore][/tt] tags.

Feherke.

http://rootshell.be/~feherke/

 

[BillyRayPreachersSon]

Without seeing the real CLIENT-SIDE code, it would be impossible to guess. The code you've posted is NOT client-side, and is riddled with syntax errors.

However, chances are that most, if not all of these would be parsed out when delivered to the browser, so you'll have to show us that, or we've nothing to go on.

One error I can see, however, is the use of HTML comments inside a JS script block. Replace these and see if the error goes away.

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[BillyRayPreachersSon]

CF7,

Did removing the comment fix the problem?

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[feherke]

Hi

Dan, personally I think you are right about the HTML comment inside the [tt]script[/tt] tags. But seems that browsers does not bother to yell because that. I tried this and both [tt]alert()[/tt]s appeared.

<script language="javascript">
function clicked()
{
  alert('before');
  <!--- document.getElementById("fileLink").style.color="50141E"; --->
  alert('after');
}
</script>

Tested in FireFox, Opera and Explorer. None objected. Not even a warning in the JavaScript Console. Neither in XHTML Strict ( added [tt]type[/tt] attribute and removed third dashes to validate ).

Feherke.

http://rootshell.be/~feherke/