Need help with excel macro

[ncolsgk]

I have a spreadsheet with 30,932 rows. Column C has a ton of cells that have blank spaces at the end of the text which I would like to delete. I know that I need to include the Trim function but how do I setup the macro so that it goes from C1, to C2, to C3, to C4, etc?

This is what I have so far:

Application.ActiveCell = Trim(Application.ActiveCell)

 

[xlhelp]

If you select all cells you wish to trim, then you could run the following

Dim curcell As Object
For Each curcell In Selection
curcell.Value = Trim(curcell.Value)
Next curcell

Member- AAAA Association Against Acronym Abusers

 

[ncolsgk]

So then it would be this?

Sub delete_spaces()
'
' select_cells Macro
' Macro recorded 4/13/2007 by me
'
'
    
Range("C2:C30104").Select
Dim curcell As Object
For Each curcell In Selection
curcell.Value = Trim(curcell.Value)
Next curcell 

End Sub

 

[SkipVought]

Yes, but...

Either select the range and run the code without the SELECT statement or...

Dim curcell As Object
For Each curcell In Range("C2:C30104")
curcell.Value = Trim(curcell.Value)
Next curcell

in either case you do NOT need to use the Select Method in your code.

Skip,

_[red][/red]

 

[ncolsgk]

Sweet jebus that worked! Thanks!

Now I just need help with one more and I will be a happy camper.

I would like to select all cells in column A (A2:A30104) and delete the hyphen/dash at the end.

So instead of:

210-20057-56310-

It will be:

210-20057-56310

 

[SkipVought]

Is there ALWAYS a trailing DASH?

If so, you can use the Left & Len functions.



Skip,

_[red][/red]

 

[ncolsgk]

Not all cells have a trailing dash.

 

[SkipVought]

But if there is one there is ONLY ONE?

Dim curcell As Object
For Each curcell In Range("C2:C30104")
  if right(curcell.value,1) = "-" then
    curcell.value = left(curcell.value, len(curcell.value)-1)
  end if
Next curcell

Skip,

_[red][/red]

 

[ncolsgk]

THANKS!!!