NaN when it should be a string?

[unktehi]

This is the page I'm working on:

http://www.midnight007.com/test/OSlink.htm

Ideally when a complicated link such as:

http://www.overstock.com/cgi-bin/d2...PAGE=CATLIST&PRO_SUB_CAT=508&PRO_SSUB_CAT=999

is pasted into the form and the button is pushed, I'd like strip out uneeded parts, however, for some reason, when I split it, where it should display the array of parts, it comes up with NaN. Any idea why - when it should be displaying the strings?

 

[theniteowl]

There are two minor problems in your code.
First, you need to declare the variable html outside of your loop otherwise you are re-declaring it every iteration of the loop. Also, you need to assign it a default value since you cannot use += on something that has no value to begin with.

The second issue is just that you used =+ instead of +=.
The code below should work for you.

[COLOR=red]var html = '';[/color]
for(i=0; i<val1.length; i++) {
	html [COLOR=red]+=[/color] val1[i];
	//alert(html);
		 }

At my age I still learn something new every day, but I forget two others.

 

[unktehi]

I've made those small changes in the code, but now it doesn't do anything. I'm getting the error the cleanLink() is not defined - but I think this error is misleading, because I didn't change anything relating to that.

http://www.midnight007.com/test/OSlink.htm

 

[theniteowl]

Change this:

[COLOR=red]var [/color]html += val1[i];

to this:

var html += val1[i];

With the var in front of it you are redefining the variable every iteration through the loop.
It is also causing an error when the page loads so your script does not run.

At my age I still learn something new every day, but I forget two others.

 

[kaht]

I think niteowl meant to remove the var from his 2nd code box.

-kaht

Looking for a puppy?

[small]Silky Terriers are small, relatively odorless dogs that shed no fur and make great indoor pets.[/small]

 

[unktehi]

I removed the var - but I'm still getting errors and no actions are taking place:

http://www.midnight007.com/test/OSlink.htm

 

[trollacious]

You haven't removed the var on the website as of this posting. You can't initialize a variable using +=, which is what your code does.

Lee

 

[trollacious]

Looking at your code (rather than the Firefox JS console), you mistakenly removed the var from the initialization on line 72, not from line 74.

Lee

 

[unktehi]

I change that and took the vars out in both places. I re-uploaded it in and it works like it did before - going through each string separately - but not listing them all out.

 

[trollacious]

You really need to pay attention yourself to the code you've written rather than expect everyone here to debug every detail. This:

Parts.innerHTML ="" + val1[i] + "<br>";

should be

Parts.innerHTML [b][red]+[/red][/b]= val1[i] + "<br>";

Lee

 

[theniteowl]

I change that and took the vars out in both places. I re-uploaded it in and it works like it did before - going through each string separately - but not listing them all out.

You have to initialize the variable using var so the line OUTSIDE of the loop should be: var html = '';

Inside the loop you need:
html += val1;
If you have var in front of that line you are re-initializing the variable which would set it to no value then trying to use += on a variable with a null value which will cause you an error.

Partly this is my fault. In my post above I said "Replace this... With this...." and I neglected to remove the word var in the "With this...." portion. I was cutting and pasting and just forgot to exempt that piece so it was confusing.


At my age I still learn something new every day, but I forget two others.

 

[unktehi]

trollacious - I would love to - but I don't know javascript well enough yet to know exactly what to look for with some errors.

Thank you both I got it to work!