Merging FOREACH with IF : possible?? 2

[Sleidia]

Hi,

I'm wondering if it possible to simplify the following code by giving FOREACH an ability to handle conditions by itself without having to use a sub IF statement as seen below :

foreach ($array as $key => $value) {

    if (strstr($value, "something")) {
    
    do_something();
    
    }

}

Thanks

 

[feherke]

Hi

Nope. But you can do the filtering before the looping if you use a function like this :

foreach ([url=http://php.net/preg_grep/]preg_grep[/url]('/something/',$array) as $key => $value) {
  do_something();
}

I would suggest to stay with your original code.

Feherke.

http://rootshell.be/~feherke/

 

[Sleidia]

Thanks Feherke

I would suggest to stay with your original code.

But why do you suggest so?

 

[feherke]

Hi

The perceivable effect depends on the size of the array, but generally is slower and uses more memory, because
[ul]
[li]with [tt]preg_grep()[/tt] you have to use regular expression even for the simplest substring search[/li]
[li][tt]preg_grep()[/tt] builds a new array on the fly[/li]
[/ul]


Feherke.

http://rootshell.be/~feherke/

 

[Sleidia]

Oh OK, thanks again

 

[jpadie]

and you could always use array_walk instead of the foreach and then conditionalise the doSomething()

array_walk($array, 'doSomething');

function doSomething(&$value, $key){
  static $c =0;
  if ($value ==='something'){
     $value  = "something Else ($c)";
  }
  $c++;
}

 

[Sleidia]

Thanks jpadie

But unfortunately, I don't like the idea of creating a function for every condition.

 

[jpadie]

you wouldn't be. your function is there already as per your first post (doSomething()). so instead you are adding the condition to the function that you are already creating.