memory leak problem 2

[Guest_imported]

#include "DENOM.H"

Denomination:enomination ( ) // default constructor
{
value=0;
count=0;
plural= NULL; // plural and sing are char pointers
sing= NULL;
}

Denomination:enomination ( int d, char * s, char *m ) // Initialization constructor
{
value=d;
count=0;
sing=new.char[strlen(s)+1];
strcpy(sing,s);
if (!m)
plural= NULL;
else
plural=new.char[strlen(m)+1];
strcpy(plural,m);

}

Denomination::~Denomination () // Destructor
{
if (sing)
delete[] sing;
if (plural)
delete[] plural;
}

void Denomination::change ( long & amount )
{
count=value/amount;
amount%=value
}

void Denomination:rint ()
{
if (count==1)
cout << count << sing;
else if (count>1)
cout << count << plural;

}
this is giving this error
a:\denom.h(2) : warning C4182: #include nesting level is 363 deep; possible infinite recursion
a:\denom.h(2) : fatal error C1076: compiler limit : internal heap limit reached; use /Zm to specify a higher limit
Error executing cl.exe.

please help this is due tomarrow!!!!!!!!!!!!!!

 

[Cagliostro]

//a correct structure of a header file
////DENOM.H
#if !defined(__DEMON_H)//if is defined, will be not included
#define __DEMON_H

.....your declarations here


#endif John Fill

ivfmd@mail.md

 

[GEAK]

You didn't indicate what the name of this file is. I'm assuming that it is called denom.h and if so, denom.h is including itself. That will cause infinite recursion.

Incidentally, you've got a glitch in the initializing c'tor. The last line: strcpy(plural, m); should be inside braces following the else clause - you don't want to do a strcpy if plural is NULL.

 

[Cagliostro]

For example I don't see here any problemsin code below. There will not be infinite recursion, against selfincluding.


//this is file denom.h
#if !defined(__DENOM_H)//if is defined, will be not included
#define __DENOM_H
#include&quot;denom.h&quot;
.....see your declarations here


#endif John Fill

ivfmd@mail.md