Mapping data

[kensington45]

I have something that works with data mapping but was wondering if there was a more efficient way to do this?

Java part:

....
//database part here...ResultSet rs
...

List myMap = new ArrayList();
 
while (rs.next())
{
    String firstname = rs.getString("firstname");
    String lastname = rs.getString("lastname");
    String address = rs.getString("address");
    myMap.add(firstname + "," + lastname + "," + address); 
}

output:

  //output comma delimeter data     
  out.print(myMap.get(0));

Please advise.

 

[tom62]

Your code is correct. My only recommandation is to use a StringBuffer or StringBuilder to fill the myMap. StringBuffers/Builders are mutable, and if you append a value, you don't need to create extra objects.

List myMap = new ArrayList();
StringBuilder buf;
while (rs.next()) {
buf = new StringBuilder(200);
buf.append(rs.getString("firstname")),
buf.append(",");
buf.append(rs.getString("lastname"));
buf.append(",");
buf.append(rs.getString("address"));
myMap.add(buf.toString());
}

 

[Diancecht]

Some ideas:

1.- Are you using the map for anything else? If not, you can just print the result

2.- Side thinking: use the database with select field1 + field2


Cheers,
Dian