Loop through Checkboxes

[HisMightiness]

I have a script where I return true if any checkboxes are checked. However, it only works in IE. Firefox throws an error on the For loop line. It says that "col has no properties".

How can I ammend this to make it cross-browser compatible?

Here is the snippet:

function areAttractionCheckboxesSelected(){
var ctrl = document.getElementById('checkboxname');
var col = ctrl.all;

for (i = 0; i < col.length; i++){
if (col.tagName.toUpperCase() == 'INPUT'){
if(col.checked){
return true;
}
}
}
return false;
}

Will

http://www.StrohlSiteDesign.com/

 

[BillyRayPreachersSon]

You've probably used sloppy "IE-only" HTML code, and given your checkboxes names, but used the "ID" methods to get references to them.

Assuming that is the case, then instead of using this:

var ctrl = document.getElementById('checkboxname');
var col = ctrl.all;

try this:

var col = document.forms['yourFormName'].elements['checkboxname'];

Hope this helps,
Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[HisMightiness]

Unfortunately, that didn't work. I was left with the same error on the same line.

Will

http://www.StrohlSiteDesign.com/

 

[feherke]

Hi

May I be skeptic ? Dan's suggestion should work. Could you give us an URL to that page ?

Feherke.

http://rootshell.be/~feherke/

 

[HisMightiness]

Here is the method I have just found that works in both IE and Firefox:

    var ctrl = document.getElementById('CheckboxContainerID');
	var col = ctrl.getElementsByTagName('input');
	
	for (i = 0; i < col.length; i++){
	    if (col[i].tagName.toUpperCase() == 'INPUT'){
	        if(col[i].checked){
	            return true;
	        }
	    }
	}
	return false;

Will

http://www.StrohlSiteDesign.com/

 

[BillyRayPreachersSon]

Aaah - you probably have elements other than checkboxes with the same names as the chckboxes. If so, of course the original code would break.

Dan



Coedit Limited - Delivering standards compliant, accessible web solutions

[tt]Dan's Page [blue]@[/blue] Code Couch

http://www.codecouch.com/dan/

[/tt]

 

[HisMightiness]

There are additional elements, but they are table elements that are dynamically generated at run-time. The IDs should be unique. However, I would imagine that the names are not. I have not checked since it began working, sorry.

Will

http://www.StrohlSiteDesign.com/