LISP: If, Not 1

[Volk359]

Greetings all,

I've created a lisp routine to automatically repath an image that had already been inserted but where the path/filename was incorrect. It works fine but the problem is the image type isn't always the same, i.e. sometimes they are a .TIF and others they are a .CAL.

I included an IF NOT command where if it didn't find filename.CAL then go find filename.TIF. Seems to me I have the syntax correct but apparently not because if it doesn't find the .CAL it just quits. Likewise if I swap the CAL and TIF it will only find the TIF but not the CAL.

Any suggestions?

Thanks,

Keith

(setq imagename (getvar "dwgname"))
(setq imagename (substr imagename 1 (- (strlen imageName) 4)))
(setq filename (strcat (getvar "dwgprefix") imagename ".cal"))
(if (not filename)
    (setq filename (strcat (getvar "dwgprefix") filename ".tif"))
)
(command "image" "p" imagename filename)

 

[CarlAK]

It seems you don't have the routine actually looking if the "filename" exists, you just assign it a string/name, so it would never be 'nil'

Maybe changing one line to the following will do it;

(if (not (findfile filename))

 

[Volk359]

OK, that seems to work except it's looking for filename.CAL.TIF. I inserted the line to strip out the last three characters and put the whole thing together properly but I get:

Unknown command "C:\DOCUMENTS AND SETTINGS\me\DESKTOP\filename.cal". Press F1 for help.
nil

(setq imagename (getvar "dwgname"))
(setq imagename (substr imagename 1 (- (strlen imageName) 4)))
(setq filename (strcat (getvar "dwgprefix") imagename ".cal"))
(if (not (findfile filename))
    (setq imagename (substr imagename 1 (- (strlen imageName) 4)))
    (setq filename (strcat (getvar "dwgprefix") filename ".tif"))
)
(command "image" "p" imagename filename)

 

[CarlAK]

I think your "if" got messed up, you wanted 2 statements to occur if not. Slightly different coding:

(setq imagename (getvar "dwgname"))
(setq imagename (substr imagename 1 (- (strlen imageName) 4)))
(setq filename (strcat (getvar "dwgprefix") imagename ".cal"))
(if (not (findfile filename))
    (setq filename (strcat (getvar "dwgprefix") imagename ".tif"))
)
(command "image" "p" imagename filename)

 

[Volk359]

I see, by swapping IMAGENAME and FILENAME I don't have to strip out the file extension and reassemble it.

Thanks much!!.