ksh to perl??

adamf · May 29, 2002

Hi,

Could anyone convert this script to perl for me... Having dome real problems getting it to run through apache as a shell script...

Code:

#!/bin/ksh

#
#       Simple script to run CheckProgressLog to HTML
#
WEBPAGE=&quot;/users/web/docs/adamlog.html&quot;

function HEADER {
echo &quot;<html>

<head>
<meta http-equiv=\&quot;Content-Type\&quot;
content=\&quot;text/html; charset=iso-8859-1\&quot;>
<meta name=\&quot;GENERATOR\&quot; content=\&quot;Script generated by $PROC\&quot;>
<title>Extract from /var/log/progress.log</title>
</head>

<body bgcolor=\&quot;#FFFFFF\&quot;>
<table border=\&quot;0\&quot; cellpadding=\&quot;3\&quot;>
<tr><td width=\&quot;25%\&quot;>
<IMG BORDER=0 SRC=\&quot;/images/ctlogo.jpg\&quot; WIDTH=99 HEIGHT=33 ALT=\&quot;ux-gbbri-mk1\&quot;>
</td>
<TD WIDTH=\&quot;75%\&quot;><CENTER>
<H1>Extract from /var/log/progress.log</H1></CENTER></TD>
</tr></TABLE>
<table border=\&quot;0\&quot; cellpadding=\&quot;3\&quot;>
    <tr>
        <td><b>Hostname:</b></td>
        <td>`uname -n`</td>
    </tr>
</table>

<HR>
<FONT SIZE=\&quot;4\&quot;>
The following data is an extract of the last 100 lines of the 
/var/log/progress.log . This report<BR>
is printed in reverse order with the youngest entry at the top 
and oldest at the bottom.
<PRE>
<FONT SIZE=\&quot;2\&quot;>&quot;
}

function TRAILER {
echo &quot;
</PRE>
<HR>
<P ALIGN=\&quot;CENTER\&quot;>
<A HREF=\&quot;./additional_reports.html\&quot;>BACK</A>
</P>
Last Updated at `date`
</body>
</html>
&quot; 
}


exec > $WEBPAGE

HEADER
/usr/local/apache/cgi-bin/log_print.ksh -L
TRAILER

Thanks in advance!! Adam F
Solaris System Administrator

NEVERSLEEP · May 30, 2002

#!/usr/bin/local/perl -w
# i dont know much on ksh
# but it look as u need something like
use strict;

my $webpage = ""/users/web/docs/adamlog.html";

&readfile;
&makeheader;
foreach (@datastorer) {print "$_<br>";}
&makemaketrailer;
&endofscript;

sub readfile {
open (FILE, $webpage&quot

|| die endofscript($!);
my @datastorer = <FILE>;
close (FILE) || die endofscript($!);
}

sub makeheader {
print "Content-type: text/html\n\n";
print "<html>
<head>
<meta http-equiv=\"Content-Type\"
content=\"text/html; charset=iso-8859-1\">
<meta name=\"GENERATOR\" content=\"Script generated by $0\">
<title>Extract from /var/log/progress.log</title>
</head>
<body bgcolor=\"#FFFFFF\">
<table border=\"0\" cellpadding=\"3\">
<tr><td width=\"25%\">
<IMG BORDER=0 SRC=\"/images/ctlogo.jpg\" WIDTH=99 HEIGHT=33 ALT=\"ux-gbbri-mk1\">
</td>
<TD WIDTH=\"75%\"><CENTER>
<H1>Extract from /var/log/progress.log</H1></CENTER></TD>
</tr></TABLE>
<table border=\"0\" cellpadding=\"3\">
<tr>
<td><b>Hostname:</b></td>
<td>`uname -n`</td>
</tr>
</table>
<HR>
<FONT SIZE=\"4\">
The following data is an extract of the last 100 lines of the
/var/log/progress.log . This report<BR>
is printed in reverse order with the youngest entry at the top
and oldest at the bottom.
<PRE>
<FONT SIZE=\"2\">";
}

sub maketrailer {
print "</PRE>
<HR>
<P ALIGN=\"CENTER\">
<A HREF=\"./additional_reports.html\">BACK</A>
</P>
Last Updated at `date`
</body>
</html>";
}

sub endofscript {
if ($_[0]) {
print "Content-type: text/html\n\n<html>DEAD : $_[0]";
}
exit;
}

#
# hope this help u ---------------------------------------

someone knowledge ends where
someone else knowledge starts

adamf · Jun 5, 2002

Hi... Looks good, but when I tried to run it, it was fill of holes!

I am pretty clueless when it comes to Perl, so don't have a chance of debugging it myself...

If you get a chance, could you run thru it again & see if you can spot any problems? Here is a dump of the errors...

Code:

String found where operator expected at /usr/local/apache/cgi-bin/Log2HTML.pl line 23, near &quot;print &quot;&quot;
  (Might be a runaway multi-line &quot;&quot; string starting on line 17)
        (Missing semicolon on previous line?)
Possible unintended interpolation of @datastorer in string at /usr/local/apache/cgi-bin/Log2HTML.pl line 17.
Bareword found where operator expected at /usr/local/apache/cgi-bin/Log2HTML.pl line 23, near &quot;print &quot;Content&quot;
        (Do you need to predeclare print?)
Backslash found where operator expected at /usr/local/apache/cgi-bin/Log2HTML.pl line 23, near &quot;html\&quot;
Backslash found where operator expected at /usr/local/apache/cgi-bin/Log2HTML.pl line 23, near &quot;n\&quot;
String found where operator expected at /usr/local/apache/cgi-bin/Log2HTML.pl line 24, near &quot;print &quot;&quot;
  (Might be a runaway multi-line &quot;&quot; string starting on line 23)
        (Missing semicolon on previous line?)
Global symbol &quot;@datastorer&quot; requires explicit package name at /usr/local/apache/cgi-bin/Log2HTML.pl line 11.
syntax error at /usr/local/apache/cgi-bin/Log2HTML.pl line 23, near &quot;print &quot;&quot;
Global symbol &quot;@datastorer&quot; requires explicit package name at /usr/local/apache/cgi-bin/Log2HTML.pl line 17.
Execution of /usr/local/apache/cgi-bin/Log2HTML.pl aborted due to compilation errors.

Adam F
Solaris System Administrator

Coderifous · Jun 5, 2002

What was apache's problem with running it as a shell script?

--jim

adamf · Jun 5, 2002

A 'Premature end of script headers' message....

Adam F
Solaris System Administrator

NEVERSLEEP · Jun 5, 2002

#!/usr/bin/local/perl -w
# will this be better ?
# perl -c returned no errors
use strict;

my $webpage = "/users/web/docs/adamlog.html";
my $uname = `uname -n`;
my $date = `date`;
my @datastorer;

&readfile;
&makehtml;
&endofscript;

sub readfile {
open (FILE, "$webpage&quot

|| die &endofscript($!);
@datastorer = <FILE>;
close (FILE) || die endofscript($!);
}

sub makehtml {
print "Content-type: text/html\n\n";
print "<html><head><meta http-equiv=\"Content-Type\" content=\"text/html; charset=iso-8859-1\">";
print "<meta name=\"GENERATOR\" content=\"Script generated by $0\">";
print "<title>Extract from /var/log/progress.log</title>";
print "</head><body bgcolor=\"FFFFFF\"><table border=\"0\" cellpadding=\"3\"><tr><td width=\"25%\">";
print "<IMG BORDER=0 SRC=\"/images/ctlogo.jpg\" WIDTH=99 HEIGHT=33 ALT=\"ux-gbbri-mk1\">";
print "</td><TD WIDTH=\"75%\"><CENTER><H1>Extract from /var/log/progress.log</H1></CENTER></TD>";
print "</tr></TABLE><table border=\"0\" cellpadding=\"3\"><tr><td><b>Hostname:</b></td><td>$uname</td>";
print "</tr></table><HR><FONT SIZE=\"4\">The following data is an extract of the last 100 lines of the";
print "/var/log/progress.log . This report<BR>is printed in reverse order with the youngest entry at the top";
print "and oldest at the bottom.<font size=\"2\"><PRE>";
foreach (@datastorer) {
print "$_<br>";
}
print "</PRE><HR><P ALIGN=\"CENTER\">";
print "<A HREF=\"./additional_reports.html\">BACK</A>";
print "</P>Last Updated at $date</body></html>";
}

sub endofscript {
if ($_[0]) {print "Content-type: text/html\n\n<html>DEAD : $_[0]";}
exit;
} ---------------------------------------

someone knowledge ends where
someone else knowledge starts

NEVERSLEEP · Jun 5, 2002

sub endofscript {
if ($_[0]) {print "Content-type: text/html\n\n<html>DEAD : $_[0]";}
exit;
}

# should be

sub endofscript {
if ($_[0]) {print "Content-type: text/html\n\n<html>DEAD : $_[0]</html>";}
exit;
} ---------------------------------------

someone knowledge ends where
someone else knowledge starts

yauncin · Jun 5, 2002

you could have just added this to the shell script. where you have:

function HEADER {
echo "<html>

do this:

function HEADER {
echo "content-type: text/html

<html>

yauncin · Jun 5, 2002

Sorry... here is an explanation. The client's browser is expecting 'header' information. The 'content-type: text/html' lets the browser know what type of information is being sent. There is other header info you can send also, but the above info is all you need to print to the browser.

adamf · Jun 6, 2002

I tried that earlier on.... But I got the same error. Adam F
Solaris System Administrator

yauncin · Jun 6, 2002

thats weird i've created bash cgi scripts before....

Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

ksh to perl??

adamf

Technical User

NEVERSLEEP

Programmer

adamf

Technical User

Coderifous

Programmer

adamf

Technical User

NEVERSLEEP

Programmer

NEVERSLEEP

Programmer

yauncin

Programmer

yauncin

Programmer

adamf

Technical User

yauncin

Programmer

Similar threads

Part and Inventory Search

Sponsor