Korn shell script doesn't change directory 4

[varocho]

Maybe one of you can help me figure out what's wrong with the following shell script I wrote earlier today, it's supposed to change directory to the 'ams' application subdirectory, and then print out the name of every file in this subdirectory, as well as display any and all lines within each file containing the word 'reference' (I try running this script from my home directory, but the script doesn't change the directory to the 'ams' subdirectory for some reason):

# shell script to list names of scripts containing the phrase 'reference'

$dirName = "/hpnpages/cgi-bin/applinks/ams"
cd $dirName

for fileName in `ls`
do
if (test -f $fileName)
then
print "Current file name is $fileName\n"
cat $fileName | grep 'reference'
print "\n"
fi
done

cd $HOME

 

[elgrandeperro]

Not:
$dirName = "/hpnpages/cgi-bin/applinks/ams"
but:
dirName="/hpnpages/cgi-bin/applinks/ams"

(take spaces, no $ sign)

eugene

 

[varocho]

Thanks, Eugene, much appreciated. If you and/or anyone else here has any recommendations on a good book on Korn shell programming, I'm all ears, er, eyes.

 

[Annihilannic]

A couple of other suggestions:

[tt]for fileName in *[/tt]

Saves an extra shell and /usr/bin/ls invocation.

[tt]grep 'reference' $fileName[/tt]

Saves an unnecessary cat process.

A good starting point would be the site of David Korn himself:

http://www.kornshell.org/

Annihilannic.

 

[olded]

For a beginner:

Unix Shell Programming by Stephen Kochan & Patrick Wood

Get the 3rd edition.

 

[PHV]

list names of scripts containing the phrase 'reference'
A one line way:

grep -l 'reference' /hpnpages/cgi-bin/applinks/ams/*

Hope This Helps, PH.
FAQ219-2884
FAQ181-2886

 

[varocho]

Many thanks to all of you who took the time to answer the question of a Unix newbie.

 

[Martin999]

Also check out the ksh man page, some good stuff, though a little difficult to read sometimes.

Martin