Tek-Tips is the largest IT community on the Internet today!

Members share and learn making Tek-Tips Forums the best source of peer-reviewed technical information on the Internet!

  • Congratulations Mike Lewis on being selected by the Tek-Tips community for having the most helpful posts in the forums last week. Way to Go!

JS newbie problem (remove element from a list) 1

Status
Not open for further replies.

bobens83

Programmer
Dec 26, 2008
1
PL
Hi there.

It's my firts post here in Your forum so I'd like to say HELLO WORLD ;)

I admit that's my first steps in JS. It causes me a problem at a beginning ;)




<script >
function addElement() {
var ni = document.getElementById('myDiv');
var numi = document.getElementById('theValue');
var num = (document.getElementById('theValue').value -1)+ 2;
numi.value = num;

var newdiv = document.createElement('div');
var divIdName = 'my'+num+'Div';
newdiv.setAttribute('id',divIdName);
newdiv.innerHTML = 'Element Number '+num+' has been added! <a href=\'#\' onclick=\'removeElement('+divIdName+')\'>Remove the div "'+divIdName+'"</a>';

ni.appendChild(newdiv);

}

function removeElement(divNum) {
var d = document.getElementById('myDiv');
var olddiv = document.getElementById(divNum);
d.removeChild(olddiv);

}
</script>

<html>

<input type="hidden" value="0" id="theValue" />

<p><a href="javascript:;" onclick="addElement();">Add Some Elements</a></p>
<div id="myDiv"> </div>

</html>




After pressing 'Add Some Elements' link a new element is shown in the screen.

For example element:
Element Number 3 has been added! Remove the div "my3Div"

... But when I press 'Remove the div "my3Div"' link - element is not deleted :(

Where can be the problem? I'll be thankful for tips. Greetings.

 
You have to call removeElement with string argument. Right now the code generated by newdiv.innerHTML looks like onclick='removeElement(my3Div)'. But it has to be onclick='removeElement("my3Div")'

Code:
 newdiv.innerHTML = 'Element Number '+num+' has been added! <a href=\'#\' onclick=\'removeElement([COLOR=red][b]"[/b][/color]'+divIdName+'[COLOR=red][b]"[/b][/color])\'>Remove the div "'+divIdName+'"</a>';

Avar Pentel
 
Status
Not open for further replies.

Part and Inventory Search

Sponsor

Back
Top