javascript onclick function in firefox

[DannyTmoov2]

Can someone tell me what's wrong in firefox's eyes with the below? When you hit the hyperlink nothing happens: -


<script language="JavaScript" type="text/JavaScript">
// enter button for login script
function submitenter(myfield,e)
{

var keycode;
if (window.event) keycode = window.event.keyCode;
else if (e) keycode = e.which;
else return true;

if (keycode == 13)
{
login.submit();
return false;
}
else
return true;
}
</script>

...


<A href="javascript:login.submit();">go</a>

 

[cLFlaVA]

Proper syntax:

<a href="#" onclick="document.forms['login'].submit(); return false;">go</a>

*cLFlaVA
----------------------------
[tt]insert funny quotation here.[/tt]

 

[tgreer]

Something strange with the whole use of "e". The hyperlink doesn't show you using this function, but I assume you are somewhere.

The "test" you need to make is if the event object uses "keyCode" (IE) or "which" (FF):

<script type="text/javascript">
function submitenter(myfield,e)
{
   var keycode;

   if (navigator.appName == "Microsoft Internet Explorer")
   {
     keycode = e.keyCode;
   }
   else
   {
     keycode = e.which
   }

   if (window.event)
   {
     keycode = window.event.keyCode;
   }
   else
   if (e)
   {
     keycode = e.which;
   }

   if (keycode == 13)
   {
     login.submit();
     return false;
   }
   else
   {
     return true;
   }
}
</script>

And you have to call the function with the event:

<... onclick="submitenter(this,event)"; />

There is an article on my site that uses this code. The article is "Creating an HTML "ComboBox" control".



Thomas D. Greer

http://www.tgreer.com

Providing PostScript & PDF
Training, Development & Consulting

 

[tgreer]

Sorry, I had some of your code still in there:

<script type="text/javascript">
function submitenter(myfield,e)
{
   var keycode;

   if (navigator.appName == "Microsoft Internet Explorer")
   {
     keycode = e.keyCode;
   }
   else
   {
     keycode = e.which
   }

   if (keycode == 13)
   {
     return true;
   }
   else
   {
     return false;
   }
}
</script>

I left out the code for what to do if the keycode==13, but return false if you don't want the form to submit, return true if you do.



Thomas D. Greer

http://www.tgreer.com

Providing PostScript & PDF
Training, Development & Consulting